Skip to content

Commit 8e91dc9

Browse files
fix(typings): Change Ng1ViewDeclaration.controller type to IInjectable|string
1 parent d2b5d84 commit 8e91dc9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/ng1/statebuilders/views.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { ng as angular } from "../../angular";
33
import {
44
State, Obj, pick, forEach, anyTrueR, unnestR, tail, extend, kebobString,
55
isArray, isInjectable, isDefined, isString, isObject, services, trace,
6-
ViewConfig, ViewService, ViewConfigFactory, PathNode, ResolveContext, Resolvable, RawParams
6+
ViewConfig, ViewService, ViewConfigFactory, PathNode, ResolveContext, Resolvable, RawParams, IInjectable
77
} from "ui-router-core";
88
import { Ng1ViewDeclaration } from "../interface";
99
import { TemplateFactory } from "../templateFactory";
@@ -110,7 +110,7 @@ let id = 0;
110110
export class Ng1ViewConfig implements ViewConfig {
111111
$id = id++;
112112
loaded: boolean = false;
113-
controller: Function;
113+
controller: Function; // actually IInjectable|string
114114
template: string;
115115
locals: any; // TODO: delete me
116116

@@ -156,7 +156,7 @@ export class Ng1ViewConfig implements ViewConfig {
156156
*
157157
* @returns {Function|Promise.<Function>} Returns a controller, or a promise that resolves to a controller.
158158
*/
159-
getController(context: ResolveContext): (String|Function|Promise<Function|String>) {
159+
getController(context: ResolveContext): (IInjectable|string|Promise<IInjectable|string>) {
160160
let provider = this.viewDecl.controllerProvider;
161161
if (!isInjectable(provider)) return this.viewDecl.controller;
162162
let deps = services.$injector.annotate(provider);

0 commit comments

Comments
 (0)