fix($stateChangeSuccess): fire polyfill $stateChangeSuccess right after global state are updated

christopherthielen · christopherthielen · commit 3984f9b6f31a · 2016-11-09T18:55:17.000-06:00
Closes #3144
diff --git a/src/ng1/legacy/stateEvents.ts b/src/ng1/legacy/stateEvents.ts
@@ -182,9 +182,11 @@ export var $stateNotFound: IAngularEvent;
         return false;
       }
 
-      $transition$.promise.then(function () {
+      // right after global state is updated
+      let successOpts = { priority: 9999 };
+      $transition$.onSuccess({}, function () {
         $rootScope.$broadcast('$stateChangeSuccess', $transition$.to(), toParams, $transition$.from(), fromParams, $transition$.options(), $transition$);
-      });
+      }, successOpts);
     }
 
     if (enabledEvents.$stateChangeError) {

Original file line number	Diff line number	Diff line change
`@@ -182,9 +182,11 @@ export var $stateNotFound: IAngularEvent;`
`182`	`182`	`return false;`
`183`	`183`	`}`
`184`	`184`
`185`		`- $transition$.promise.then(function () {`
	`185`	`+ // right after global state is updated`
	`186`	`+ let successOpts = { priority: 9999 };`
	`187`	`+ $transition$.onSuccess({}, function () {`
`186`	`188`	`$rootScope.$broadcast('$stateChangeSuccess', $transition$.to(), toParams, $transition$.from(), fromParams, $transition$.options(), $transition$);`
`187`		`- });`
	`189`	`+ }, successOpts);`
`188`	`190`	`}`
`189`	`191`
`190`	`192`	`if (enabledEvents.$stateChangeError) {`