From 9eb426f67188ab7f448c3264fef1aff2e7954146 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 15:32:54 -0500 Subject: [PATCH 01/24] Update ui-grid-column-menu.js --- src/js/core/directives/ui-grid-column-menu.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-column-menu.js b/src/js/core/directives/ui-grid-column-menu.js index c30e8d18fc..dabeb8640c 100644 --- a/src/js/core/directives/ui-grid-column-menu.js +++ b/src/js/core/directives/ui-grid-column-menu.js @@ -426,7 +426,7 @@ function ($timeout, gridUtil, uiGridConstants, uiGridColumnMenuService, $documen .then(function () { $scope.grid.refresh(); $scope.hideMenu(); - }); + }).catch(angular.noop); }; $scope.unsortColumn = function () { From b8754687f4fadf5ecd74ba3b506dc77ca0f69b94 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 15:36:41 -0500 Subject: [PATCH 02/24] Update ui-grid-cell.js --- src/js/core/directives/ui-grid-cell.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-cell.js b/src/js/core/directives/ui-grid-cell.js index 9b9af47f48..50c69a0a6e 100644 --- a/src/js/core/directives/ui-grid-cell.js +++ b/src/js/core/directives/ui-grid-cell.js @@ -28,7 +28,7 @@ angular.module('ui.grid').directive('uiGridCell', ['$compile', '$parse', 'gridUt compiledElementFn($scope, function(clonedElement, scope) { $elm.append(clonedElement); }); - }); + }).catch(angular.noop); } else { var html = $scope.col.cellTemplate From 596c1300338ef3fcdb426bea7652ae8a12f461cf Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 15:37:54 -0500 Subject: [PATCH 03/24] Update ui-grid-footer.js --- src/js/core/directives/ui-grid-footer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/core/directives/ui-grid-footer.js b/src/js/core/directives/ui-grid-footer.js index c3a42dad2a..bc5a1b8ce5 100644 --- a/src/js/core/directives/ui-grid-footer.js +++ b/src/js/core/directives/ui-grid-footer.js @@ -36,7 +36,7 @@ containerCtrl.footerViewport = footerViewport; } } - }); + }).catch(angular.noop); }, post: function ($scope, $elm, $attrs, controllers) { @@ -62,4 +62,4 @@ }; }]); -})(); \ No newline at end of file +})(); From 3c04b5487a4cde1da122b84a9efd0492d50dea07 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 15:39:20 -0500 Subject: [PATCH 04/24] Update ui-grid-grid-footer.js --- src/js/core/directives/ui-grid-grid-footer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/core/directives/ui-grid-grid-footer.js b/src/js/core/directives/ui-grid-grid-footer.js index 85dd89b875..d0424cfa49 100644 --- a/src/js/core/directives/ui-grid-grid-footer.js +++ b/src/js/core/directives/ui-grid-grid-footer.js @@ -24,7 +24,7 @@ var newElm = $compile(template)($scope); $elm.append(newElm); - }); + }).catch(angular.noop); }, post: function ($scope, $elm, $attrs, controllers) { @@ -35,4 +35,4 @@ }; }]); -})(); \ No newline at end of file +})(); From f476fbe6201e11deb1a30d023cba6ef25ee6e7d2 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 15:51:44 -0500 Subject: [PATCH 05/24] Update ui-grid-group-panel.js --- src/js/core/directives/ui-grid-group-panel.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/core/directives/ui-grid-group-panel.js b/src/js/core/directives/ui-grid-group-panel.js index a96a58b07c..5d01af48ef 100644 --- a/src/js/core/directives/ui-grid-group-panel.js +++ b/src/js/core/directives/ui-grid-group-panel.js @@ -20,7 +20,7 @@ var newElm = $compile(template)($scope); $elm.append(newElm); - }); + }).catch(angular.noop); }, post: function ($scope, $elm, $attrs, uiGridCtrl) { @@ -33,4 +33,4 @@ }; }]); -})(); \ No newline at end of file +})(); From 19ac9be35351990e44dfb507499e6e2cc1aa1d58 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:09:20 -0500 Subject: [PATCH 06/24] Update ui-grid-header-cell.js --- src/js/core/directives/ui-grid-header-cell.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/core/directives/ui-grid-header-cell.js b/src/js/core/directives/ui-grid-header-cell.js index 5b97349bfb..45b9694790 100644 --- a/src/js/core/directives/ui-grid-header-cell.js +++ b/src/js/core/directives/ui-grid-header-cell.js @@ -119,7 +119,7 @@ if ( $scope.colMenu ) { uiGridCtrl.columnMenuScope.showMenu($scope.col, $elm, event); } - }); + }).catch(angular.noop); uiGridCtrl.fireEvent(uiGridConstants.events.COLUMN_HEADER_CLICK, {event: event, columnName: $scope.col.colDef.name}); @@ -350,7 +350,7 @@ .then(function () { if (uiGridCtrl.columnMenuScope) { uiGridCtrl.columnMenuScope.hideMenu(); } uiGridCtrl.grid.refresh(); - }); + }).catch(angular.noop); }; From 6d643464fef675cd9f60c23fd807f82b5a34091e Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:10:57 -0500 Subject: [PATCH 07/24] Update ui-grid-header.js --- src/js/core/directives/ui-grid-header.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-header.js b/src/js/core/directives/ui-grid-header.js index b72fad95e4..cab6a0d188 100644 --- a/src/js/core/directives/ui-grid-header.js +++ b/src/js/core/directives/ui-grid-header.js @@ -59,7 +59,7 @@ } $scope.grid.queueRefresh(); - }); + }).catch(angular.noop); function updateHeaderReferences() { containerCtrl.header = containerCtrl.colContainer.header = $elm; From 39070a49bdf77c5a732e8888c14731cf4614457a Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:13:20 -0500 Subject: [PATCH 08/24] Update ui-grid-menu-button.js --- src/js/core/directives/ui-grid-menu-button.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-menu-button.js b/src/js/core/directives/ui-grid-menu-button.js index 4476e95003..b8742fb89a 100644 --- a/src/js/core/directives/ui-grid-menu-button.js +++ b/src/js/core/directives/ui-grid-menu-button.js @@ -323,7 +323,7 @@ angular.module('ui.grid') menuItem.title = successValue; }, function( errorValue ) { menuItem.title = errorValue; - }); + }).catch(angular.noop); } else { gridUtil.logError('Expected gridMenuTitleFilter to return a string or a promise, it has returned neither, bad config'); menuItem.title = 'badconfig'; From ddd13f22df92b0a9e34d9bee62edcf2990b46a4b Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:15:25 -0500 Subject: [PATCH 09/24] Update ui-grid-menu.js --- src/js/core/directives/ui-grid-menu.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-menu.js b/src/js/core/directives/ui-grid-menu.js index 8b1525e6ad..820b5a3a0a 100644 --- a/src/js/core/directives/ui-grid-menu.js +++ b/src/js/core/directives/ui-grid-menu.js @@ -50,7 +50,7 @@ function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, i18 var template = angular.element(contents); var newElm = $compile(template)($scope); $elm.replaceWith(newElm); - }); + }).catch(angular.noop); } var setupHeightStyle = function(gridHeight) { From c49b5065873ede94c1f15bb0156d59a54acb9a24 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:15:59 -0500 Subject: [PATCH 10/24] Update ui-grid-menu.js --- src/js/core/directives/ui-grid-menu.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-menu.js b/src/js/core/directives/ui-grid-menu.js index 820b5a3a0a..d6e9dd24bf 100644 --- a/src/js/core/directives/ui-grid-menu.js +++ b/src/js/core/directives/ui-grid-menu.js @@ -248,7 +248,7 @@ function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, i18 var newElm = $compile(template)($scope); $elm.replaceWith(newElm); - }); + }).catch(angular.noop); } }, post: function ($scope, $elm, $attrs, controllers) { From c50e44e1e0df14073970a9e76e609de331b34185 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:19:45 -0500 Subject: [PATCH 11/24] Update ui-grid-row.js --- src/js/core/directives/ui-grid-row.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/core/directives/ui-grid-row.js b/src/js/core/directives/ui-grid-row.js index 3268375ae8..9c055caf1d 100644 --- a/src/js/core/directives/ui-grid-row.js +++ b/src/js/core/directives/ui-grid-row.js @@ -46,7 +46,7 @@ clonedElement = newElm; cloneScope = newScope; }); - }); + }).catch(angular.noop); } // Initially attach the compiled template to this scope @@ -67,4 +67,4 @@ }; }]); -})(); \ No newline at end of file +})(); From 6df766c69db4555dc68c2186a72bc13a1e20f06a Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:23:26 -0500 Subject: [PATCH 12/24] Update ui-grid.js --- src/js/core/directives/ui-grid.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/js/core/directives/ui-grid.js b/src/js/core/directives/ui-grid.js index d5dbfd0ecd..89adb15788 100644 --- a/src/js/core/directives/ui-grid.js +++ b/src/js/core/directives/ui-grid.js @@ -31,7 +31,7 @@ self.grid.preCompileCellTemplates(); self.grid.refreshCanvas(true); - }); + }).catch(angular.noop); }); } @@ -74,7 +74,7 @@ self.grid.preCompileCellTemplates(); self.grid.callDataChangeCallbacks(uiGridConstants.dataChange.COLUMN); - }); + }).catch(angular.noop); } } @@ -118,7 +118,7 @@ promises.push(self.grid.buildColumns() .then(function() { self.grid.preCompileCellTemplates(); - })); + }).catch(angular.noop)); } $q.all(promises).then(function() { @@ -133,8 +133,8 @@ self.grid.refreshCanvas(true); self.grid.callDataChangeCallbacks(uiGridConstants.dataChange.ROW); }); - }); - }); + }).catch(angular.noop); + }).catch(angular.noop); } } From f716d0bca869e51114e801ab8468844cd04ba98f Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:29:16 -0500 Subject: [PATCH 13/24] Update ui-grid-column-menu.js --- src/js/core/directives/ui-grid-column-menu.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/directives/ui-grid-column-menu.js b/src/js/core/directives/ui-grid-column-menu.js index dabeb8640c..4206bbd92b 100644 --- a/src/js/core/directives/ui-grid-column-menu.js +++ b/src/js/core/directives/ui-grid-column-menu.js @@ -480,7 +480,7 @@ function ($timeout, gridUtil, uiGridConstants, uiGridColumnMenuService, $documen //The fallback action is to focus on the grid menu return focusToGridMenu(); } - }); + }).catch(angular.noop); } else { // Fallback action to focus on the grid menu focusToGridMenu(); From a5beafe0e968d38d12a92bb6be07a1daa99d2032 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:48:26 -0500 Subject: [PATCH 14/24] Update Grid.js --- src/js/core/factories/Grid.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/js/core/factories/Grid.js b/src/js/core/factories/Grid.js index 01f5bdaa90..2217ccbd03 100644 --- a/src/js/core/factories/Grid.js +++ b/src/js/core/factories/Grid.js @@ -795,8 +795,8 @@ angular.module('ui.grid') .then( function() { self.preCompileCellTemplates(); self.queueGridRefresh(); - }); - }); + }).catch(angular.noop); + }).catch(angular.noop); }; /** @@ -1161,12 +1161,12 @@ angular.module('ui.grid') var p1 = $q.when(self.processRowsProcessors(self.rows)) .then(function (renderableRows) { return self.setVisibleRows(renderableRows); - }); + }).catch(angular.noop); var p2 = $q.when(self.processColumnsProcessors(self.columns)) .then(function (renderableColumns) { return self.setVisibleColumns(renderableColumns); - }); + }).catch(angular.noop); return $q.all([p1, p2]); }; @@ -1490,7 +1490,7 @@ angular.module('ui.grid') else { finished.resolve(myRenderableColumns); } - }); + }).catch(angular.noop); } // Start on the first processor @@ -2099,7 +2099,7 @@ angular.module('ui.grid') self.redrawInPlace(); self.refreshCanvas( true ); - }); + }).catch(angular.noop); }; /** From 996aa14b871e763837e59e093bf8880eb9384f95 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:49:32 -0500 Subject: [PATCH 15/24] Update Grid.js --- src/js/core/factories/Grid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/factories/Grid.js b/src/js/core/factories/Grid.js index 2217ccbd03..8d61623bab 100644 --- a/src/js/core/factories/Grid.js +++ b/src/js/core/factories/Grid.js @@ -913,7 +913,7 @@ angular.module('ui.grid') if (self.rows.length > 0){ self.assignTypes(); } - }); + }).catch(angular.noop); }; Grid.prototype.preCompileCellTemplate = function(col) { From b1ce6afa3058562b998398311be80da6b5c8ab5c Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:50:53 -0500 Subject: [PATCH 16/24] Update Grid.js --- src/js/core/factories/Grid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/factories/Grid.js b/src/js/core/factories/Grid.js index 8d61623bab..d08a4247df 100644 --- a/src/js/core/factories/Grid.js +++ b/src/js/core/factories/Grid.js @@ -943,7 +943,7 @@ angular.module('ui.grid') } else if ( col.cellTemplatePromise ){ col.cellTemplatePromise.then( function() { self.preCompileCellTemplate( col ); - }); + }).catch(angular.noop); } }); }; From d8bb7d44abfed606de3480f83c58006e33255e8c Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:52:22 -0500 Subject: [PATCH 17/24] Update Grid.js --- src/js/core/factories/Grid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/core/factories/Grid.js b/src/js/core/factories/Grid.js index d08a4247df..2030af1c4f 100644 --- a/src/js/core/factories/Grid.js +++ b/src/js/core/factories/Grid.js @@ -1362,7 +1362,7 @@ angular.module('ui.grid') else { finished.resolve(processedRows); } - }); + }).catch(angular.noop); } // Start on the first processor From 268f8a2ab5b29fb614f06d1fa1d68176c8ffc56f Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:57:08 -0500 Subject: [PATCH 18/24] Update Grid.js --- src/js/core/factories/Grid.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/js/core/factories/Grid.js b/src/js/core/factories/Grid.js index 2030af1c4f..ae532d768b 100644 --- a/src/js/core/factories/Grid.js +++ b/src/js/core/factories/Grid.js @@ -1563,7 +1563,7 @@ angular.module('ui.grid') self.refreshCanceller.then(function () { self.refreshCanceller = null; - }); + }).catch(angular.noop); return self.refreshCanceller; }; @@ -1588,7 +1588,7 @@ angular.module('ui.grid') self.gridRefreshCanceller.then(function () { self.gridRefreshCanceller = null; - }); + }).catch(angular.noop); return self.gridRefreshCanceller; }; @@ -2068,17 +2068,17 @@ angular.module('ui.grid') var p1 = self.processRowsProcessors(self.rows).then(function (renderableRows) { self.setVisibleRows(renderableRows); - }); + }).catch(angular.noop); var p2 = self.processColumnsProcessors(self.columns).then(function (renderableColumns) { self.setVisibleColumns(renderableColumns); - }); + }).catch(angular.noop); return $q.all([p1, p2]).then(function () { self.redrawInPlace(rowsAltered); self.refreshCanvas(true); - }); + }).catch(angular.noop); }; /** From 0e4a5bf6135e0d629594726b292edd90cf2fa92e Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 16:58:49 -0500 Subject: [PATCH 19/24] Update gridClassFactory.js --- src/js/core/services/gridClassFactory.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/core/services/gridClassFactory.js b/src/js/core/services/gridClassFactory.js index 62fe6fb455..4d8b12e21f 100644 --- a/src/js/core/services/gridClassFactory.js +++ b/src/js/core/services/gridClassFactory.js @@ -38,7 +38,7 @@ function (res) { // Todo handle response error here? throw new Error("Couldn't fetch/use row template '" + grid.options.rowTemplate + "'"); - }); + }).catch(angular.noop); } grid.registerColumnBuilder(service.defaultColumnBuilder); @@ -119,7 +119,7 @@ }, function (res) { throw new Error("Couldn't fetch/use colDef." + templateType + " '" + colDef[templateType] + "'"); - }) + }).catch(angular.noop) ); }; From 995f9a7879011dc8710ea96fdfe9712fa9d7c7aa Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 13 Jan 2017 17:02:44 -0500 Subject: [PATCH 20/24] Update ui-grid-util.js --- src/js/core/services/ui-grid-util.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/js/core/services/ui-grid-util.js b/src/js/core/services/ui-grid-util.js index 90b1a1bc85..a379c2e546 100644 --- a/src/js/core/services/ui-grid-util.js +++ b/src/js/core/services/ui-grid-util.js @@ -352,13 +352,13 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC // See if the template is itself a promise if (angular.isFunction(template.then)) { - return template.then(s.postProcessTemplate); + return template.then(s.postProcessTemplate).catch(angular.noop); } // If the template is an element, return the element try { if (angular.element(template).length > 0) { - return $q.when(template).then(s.postProcessTemplate); + return $q.when(template).then(s.postProcessTemplate).catch(angular.noop); } } catch (err){ @@ -380,7 +380,7 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC throw new Error("Could not get template " + template + ": " + err); } ) - .then(s.postProcessTemplate); + .then(s.postProcessTemplate).catch(angular.noop); }, // From 62dc0ed222053b5a77ee3b1f17178598db6d58d7 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 20 Jan 2017 09:50:52 -0500 Subject: [PATCH 21/24] Update tree-base.js --- src/features/tree-base/js/tree-base.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/features/tree-base/js/tree-base.js b/src/features/tree-base/js/tree-base.js index e6ce192a72..c3a545e5b3 100644 --- a/src/features/tree-base/js/tree-base.js +++ b/src/features/tree-base/js/tree-base.js @@ -1013,10 +1013,13 @@ if ( grid.options.treeRowHeaderAlwaysVisible === false && grid.treeBase.numberLevels <= 0 ){ newVisibility = false; } - if ( rowHeader.visible !== newVisibility ) { - rowHeader.visible = newVisibility; - rowHeader.colDef.visible = newVisibility; - grid.queueGridRefresh(); + if(rowHeader) + { + if ( rowHeader.visible !== newVisibility ) { + rowHeader.visible = newVisibility; + rowHeader.colDef.visible = newVisibility; + grid.queueGridRefresh(); + } } }, From ae9ca4251f449fe96bff3a91291d9f5514b3ac7d Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 20 Jan 2017 10:05:28 -0500 Subject: [PATCH 22/24] Update tree-base.js --- src/features/tree-base/js/tree-base.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/features/tree-base/js/tree-base.js b/src/features/tree-base/js/tree-base.js index c3a545e5b3..f556271105 100644 --- a/src/features/tree-base/js/tree-base.js +++ b/src/features/tree-base/js/tree-base.js @@ -1013,8 +1013,7 @@ if ( grid.options.treeRowHeaderAlwaysVisible === false && grid.treeBase.numberLevels <= 0 ){ newVisibility = false; } - if(rowHeader) - { + if( rowHeader ){ if ( rowHeader.visible !== newVisibility ) { rowHeader.visible = newVisibility; rowHeader.colDef.visible = newVisibility; From ba163268b212a96f4c262dd55caafa45e9c9d1b6 Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Fri, 20 Jan 2017 10:07:37 -0500 Subject: [PATCH 23/24] Update tree-base.js --- src/features/tree-base/js/tree-base.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/features/tree-base/js/tree-base.js b/src/features/tree-base/js/tree-base.js index f556271105..1caaaede38 100644 --- a/src/features/tree-base/js/tree-base.js +++ b/src/features/tree-base/js/tree-base.js @@ -1013,7 +1013,7 @@ if ( grid.options.treeRowHeaderAlwaysVisible === false && grid.treeBase.numberLevels <= 0 ){ newVisibility = false; } - if( rowHeader ){ + if ( rowHeader ) { if ( rowHeader.visible !== newVisibility ) { rowHeader.visible = newVisibility; rowHeader.colDef.visible = newVisibility; From 7467026b2a3883ec100db18f3581bee33cc4d07b Mon Sep 17 00:00:00 2001 From: dominusbelial Date: Mon, 23 Jan 2017 09:12:17 -0500 Subject: [PATCH 24/24] Update tree-base.js --- src/features/tree-base/js/tree-base.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/features/tree-base/js/tree-base.js b/src/features/tree-base/js/tree-base.js index 1caaaede38..5654644b2d 100644 --- a/src/features/tree-base/js/tree-base.js +++ b/src/features/tree-base/js/tree-base.js @@ -1013,12 +1013,10 @@ if ( grid.options.treeRowHeaderAlwaysVisible === false && grid.treeBase.numberLevels <= 0 ){ newVisibility = false; } - if ( rowHeader ) { - if ( rowHeader.visible !== newVisibility ) { - rowHeader.visible = newVisibility; - rowHeader.colDef.visible = newVisibility; - grid.queueGridRefresh(); - } + if ( rowHeader && rowHeader.visible !== newVisibility ) { + rowHeader.visible = newVisibility; + rowHeader.colDef.visible = newVisibility; + grid.queueGridRefresh(); } },