Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

The Datepicker in Safari has an error in October #1941

Closed
qa-sp opened this issue Mar 17, 2014 · 8 comments
Closed

The Datepicker in Safari has an error in October #1941

qa-sp opened this issue Mar 17, 2014 · 8 comments

Comments

@qa-sp
Copy link

qa-sp commented Mar 17, 2014

There is an issue with the Datepicker (ui.bootstrap.datepicker) in Safari.

The dates are shown incorrectly for the first weekend in October.

E.g. in 2014, Saturday is the 4th and Sunday is the 5th.
When we look at the Datepicker in Safari it shows both Saturday and Sunday as the 4th.

This pattern is repeated for 2015 and 2016 (we didn’t check past 2016)

@Foxandxss
Copy link
Contributor

I am not able to reproduce that, my safari (on osx maverick) is working just fine.

I guess that it fails even on the demo so I ask your for an screenshot or something to see it because for it it is working as expected.

@bekos
Copy link
Contributor

bekos commented Mar 17, 2014

@qa-sp This is probably a timezone issue. Please try with the latest version from master. This issue must have been solved. If not feel free to reopen.

@bekos bekos closed this as completed Mar 17, 2014
@qa-sp
Copy link
Author

qa-sp commented Mar 17, 2014

octsafari
Here are the steps we are using:
In Safari, open the website http://angular-ui.github.io/bootstrap/
Scroll down to the Datepicker.
Bring up the calendar for October.
Observe the calendar and you will see that both Saturday and Sunday are shown with the same date.

We are in Sydney, Australia and our time zone is set correctly.
The first Sunday in October is when daylight saving starts.

@Foxandxss
Copy link
Contributor

I hear you. Can you try master? (Clone the repo, install packages, run grunt on it and open the index.html on the dist folder. Then try again.

@caitp
Copy link
Contributor

caitp commented Mar 19, 2014

@Foxandxss linked this to me, after asking about the angular core infamous "australia bug", so I'll just link that as a reference. The seasons are changing, so there's no reason why DST couldn't be involved in the issue (but I haven't investigated, might be totally unrelated).

angular/angular.js#5017

@Foxandxss
Copy link
Contributor

I can confirm that the bug is gone in master, I tried myself 👍

@qa-sp
Copy link
Author

qa-sp commented Mar 21, 2014

Thanks for all your help, much appreciated. Our developers have confirmed that following @Foxandxss steps worked for them.

(But still there on the website, which is a little disconcerting)

@Foxandxss
Copy link
Contributor

@qa-sp the website version is the current one (0.10) what it is on master is what is about to come for the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants