Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 7f137ee

Browse files
fix(build): correctly generate module dependencies for custom build
Closes #100
1 parent b8044ac commit 7f137ee

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

grunt.js

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ module.exports = function(grunt) {
6262

6363
//register before and after test tasks so we've don't have to change cli options on the goole's CI server
6464
grunt.registerTask('before-test', 'lint html2js');
65-
grunt.registerTask('after-test', 'find-modules build site');
65+
grunt.registerTask('after-test', 'build site');
6666

6767
// Default task.
6868
grunt.registerTask('default', 'before-test test after-test');
@@ -86,11 +86,6 @@ module.exports = function(grunt) {
8686
grunt.config('tplModules', tplModules);
8787
grunt.config('srcModules', srcModules);
8888
}
89-
grunt.registerTask('find-modules', 'Generate ui.bootstrap and template modules depending on all existing directives', function() {
90-
grunt.file.expandDirs('src/*').forEach(function(dir) {
91-
findModule(dir.split('/')[1]);
92-
});
93-
});
9489

9590
grunt.registerTask('dist', 'Override dist directory', function() {
9691
var dir = this.args[0];
@@ -122,12 +117,14 @@ module.exports = function(grunt) {
122117
return deps;
123118
}
124119
grunt.registerTask('build', 'Create bootstrap build files', function() {
120+
125121
var srcFiles = [], tplFiles = [];
126122
if (this.args.length) {
127123
var modules = [].concat(this.args);
128124
//Find dependencies
129-
this.args.forEach(function(name) {
130-
modules = modules.concat(dependenciesForModule(name));
125+
this.args.forEach(function(moduleName) {
126+
modules = modules.concat(dependenciesForModule(moduleName));
127+
findModule(moduleName);
131128
});
132129
srcFiles = modules.map(function(name) {
133130
return 'src/' + name + '/*.js';
@@ -137,19 +134,23 @@ module.exports = function(grunt) {
137134
return 'template/' + name + '/*.html.js';
138135
});
139136
grunt.config('filename', grunt.config('filename')+'-custom');
137+
140138
} else {
141139
srcFiles = ['src/*/*.js'];
142140
tplFiles = ['template/*/*.html.js'];
141+
142+
grunt.file.expandDirs('src/*').forEach(function(dir) {
143+
findModule(dir.split('/')[1]);
144+
});
143145
}
144-
grunt.config('concat.dist.src',
145-
grunt.config('concat.dist.src').concat(srcFiles));
146-
grunt.config('concat.dist_tpls.src',
147-
grunt.config('concat.dist_tpls.src').concat(srcFiles).concat(tplFiles));
146+
grunt.config('concat.dist.src', grunt.config('concat.dist.src').concat(srcFiles));
147+
grunt.config('concat.dist_tpls.src', grunt.config('concat.dist_tpls.src').concat(srcFiles).concat(tplFiles));
148+
148149
grunt.task.run('concat min');
149150
});
150151

151152
grunt.registerTask('site', 'Create grunt demo site from every module\'s files', function() {
152-
this.requires('find-modules concat html2js');
153+
this.requires('concat html2js');
153154

154155
function breakup(text, separator) {
155156
return text.replace(/[A-Z]/g, function (match) {

0 commit comments

Comments
 (0)