Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

Commit 16b8926

Browse files
committed
Merge pull request #148 from nlaplante/ng1.2.2
NG - 1.2.2 support
2 parents 7ca68d1 + 3318cb9 commit 16b8926

14 files changed

+27570
-16350
lines changed

Gruntfile.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,8 @@ module.exports = function (grunt) {
151151
src: ['dist/angular-google-maps.js'],
152152
options: {
153153
keepRunner: true,
154-
vendor: ['http://maps.googleapis.com/maps/api/js?sensor=false&language=en', 'lib/*.js', 'dist/angular-google-maps.js'],
154+
vendor: ['http://maps.googleapis.com/maps/api/js?sensor=false&language=en','lib/jquery.js',
155+
'lib/angular.js','lib/angular-mock.js','lib/lodash.js','dist/angular-google-maps.js'],
155156
specs: ['spec/*.spec.js', 'spec/**/*.spec.js', 'spec/**/**/*-spec.js', 'spec/**/**/**/*.spec.js',
156157
'tmp/spec/js/*/spec.js', 'tmp/spec/**/*.spec.js', 'tmp/spec/**/**/*-spec.js', 'tmp/spec/**/**/**/*.spec.js'
157158
],

component.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"name": "angular-google-maps",
33
"version": "0.0.0",
44
"dependencies": {
5-
"angular": "~1.0.7"
5+
"angular": "~1.2.2",
6+
"angular-mocks": "~1.2.2"
67
}
78
}

dist/angular-google-maps.js

+8-5
Original file line numberDiff line numberDiff line change
@@ -1701,7 +1701,6 @@
17011701
this.$log = directives.api.utils.Logger;
17021702
this.$timeout = $timeout;
17031703
this.restrict = 'ECMA';
1704-
this.replace = true;
17051704
this.require = '^googleMap';
17061705
this.priority = -1;
17071706
this.transclude = true;
@@ -1892,8 +1891,10 @@
18921891

18931892
Marker.prototype.controller = [
18941893
'$scope', '$element', function($scope, $element) {
1895-
return this.getMarker = function() {
1896-
return $element.data('instance');
1894+
return {
1895+
getMarker: function() {
1896+
return $element.data('instance');
1897+
}
18971898
};
18981899
}
18991900
];
@@ -1949,8 +1950,10 @@ not 1:1 in this setting.
19491950

19501951
Markers.prototype.controller = [
19511952
'$scope', '$element', function($scope, $element) {
1952-
return this.getMarkersScope = function() {
1953-
return $scope;
1953+
return {
1954+
getMarkersScope: function() {
1955+
return $scope;
1956+
}
19541957
};
19551958
}
19561959
];

dist/angular-google-maps.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/example.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,9 @@ <h1>angular-google-maps example</h1>
285285
</div>
286286
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>
287287
<script src="http://maps.googleapis.com/maps/api/js?libraries=weather&sensor=false&language=en&v=3.13"></script>
288-
<script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.0.7/angular.js"></script>
288+
<script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.2.2/angular.js"></script>
289289
<script src="//netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/js/bootstrap.min.js"></script>
290-
<script src="http://underscorejs.org/underscore-min.js"></script>
290+
<script src="//cdn.jsdelivr.net/lodash/2.4.0/lodash.backbone.js" type="text/javascript"></script>
291291
<script src="angular-google-maps.js"></script>
292292
<script src="example-controller.js"></script>
293293
<script src="templates/infoController.js"></script>

0 commit comments

Comments
 (0)