Skip to content

Commit 3f03b5c

Browse files
authored
chore: add PR feedback (#79)
* chore: add auto0formatting to docs * chore: change deps to exact versions * fix: import error during prod build of example-app * chore: revert package version for proper auto-increment * chore: remove unneeded cli files * chore: restore changelogs * chore: add example-app prod build * chore: fix internal package declarations
1 parent e4a3c4a commit 3f03b5c

22 files changed

+313
-1173
lines changed

.prettierignore

-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
dist
22
coverage
3-
docs

.yarnrc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
--add.exact true

CHANGELOG.md

-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
# 10.0.0
2-
3-
- Supports Angular 7
4-
- Requires Node >= 8
5-
- Move to latest versions of major dependencies: typescript, immutable
6-
- Moved documentation to docsify
7-
81
# 9.0.0
92

103
## Breaking Changes

docs/CONTRIBUTING.md

-24
This file was deleted.

lerna.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"packages": ["packages/*"],
3-
"version": "10.0.0",
3+
"version": "9.0.0",
44
"npmClient": "yarn",
55
"useWorkspaces": true,
66
"ignore": "example-app",

package.json

+39-38
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
"build:store": "yarn workspace @angular-redux/store build",
1818
"build:form": "yarn workspace @angular-redux/form build",
1919
"build:router": "yarn workspace @angular-redux/router build",
20-
"release:canary": "lerna publish --canary --contents dist --dist-tag next",
20+
"build:example-app": "yarn workspace example-app build",
21+
"release:canary": "lerna publish --canary --contents dist --dist-tag next --npm-client npm",
2122
"release:stable": "lerna version",
2223
"release:stable:ci": "lerna publish from-git --contents dist",
2324
"clean": "npm-run-all -p clean:*",
@@ -47,42 +48,42 @@
4748
"node": ">=8"
4849
},
4950
"devDependencies": {
50-
"@angular/animations": "^7.0.0",
51-
"@angular/common": "^7.0.0",
52-
"@angular/compiler": "^7.0.0",
53-
"@angular/compiler-cli": "^7.0.0",
54-
"@angular/core": "^7.0.0",
55-
"@angular/forms": "^7.0.0",
56-
"@angular/platform-browser": "^7.0.0",
57-
"@angular/platform-browser-dynamic": "^7.0.0",
58-
"@angular/router": "^7.0.0",
59-
"@babel/core": "^7.0.0-0",
60-
"@babel/types": "^7.2.2",
61-
"@commitlint/cli": "^7.3.2",
62-
"@commitlint/config-conventional": "^7.3.1",
63-
"@commitlint/prompt-cli": "^7.3.1",
64-
"@types/jest": "^23.1.13",
65-
"babel-core": "^7.0.0-0",
66-
"babel-jest": "^23.0.0",
67-
"codelyzer": "^4.5.0",
68-
"docsify-cli": "^4.3.0",
69-
"husky": "^1.3.1",
70-
"jest": "^23.6.0",
71-
"jest-junit": "^6.0.1",
72-
"jest-preset-angular": "^6.0.2",
73-
"jest-zone-patch": "^0.0.10",
74-
"lerna": "^3.10.6",
75-
"lint-staged": "^8.1.0",
76-
"ng-packagr": "^4.6.0",
77-
"npm-run-all": "^4.1.3",
78-
"prettier": "~1.15.3",
79-
"redux": "^4.0.0",
80-
"rimraf": "^2.6.2",
81-
"rxjs": "^6.0.0",
82-
"tsickle": "^0.34.0",
83-
"tslib": "^1.9.0",
84-
"tslint": "^5.12.1",
85-
"typescript": "~3.2.0",
86-
"zone.js": "~0.8.26"
51+
"@angular/animations": "7.2.1",
52+
"@angular/common": "7.2.1",
53+
"@angular/compiler": "7.2.1",
54+
"@angular/compiler-cli": "7.2.1",
55+
"@angular/core": "7.2.1",
56+
"@angular/forms": "7.2.1",
57+
"@angular/http": "7.2.1",
58+
"@angular/platform-browser": "7.2.1",
59+
"@angular/platform-browser-dynamic": "7.2.1",
60+
"@angular/router": "7.2.1",
61+
"@babel/core": "7.2.2",
62+
"@babel/types": "7.3.0",
63+
"@commitlint/cli": "7.3.2",
64+
"@commitlint/config-conventional": "7.3.1",
65+
"@commitlint/prompt-cli": "7.3.1",
66+
"@types/jest": "23.3.13",
67+
"babel-jest": "23.6.0",
68+
"codelyzer": "4.5.0",
69+
"docsify-cli": "4.3.0",
70+
"husky": "1.3.1",
71+
"jest": "23.6.0",
72+
"jest-junit": "6.0.1",
73+
"jest-preset-angular": "6.0.2",
74+
"jest-zone-patch": "0.0.10",
75+
"lerna": "3.10.6",
76+
"lint-staged": "8.1.0",
77+
"ng-packagr": "4.6.0",
78+
"npm-run-all": "4.1.5",
79+
"prettier": "1.15.3",
80+
"redux": "4.0.1",
81+
"rimraf": "2.6.3",
82+
"rxjs": "6.3.3",
83+
"tsickle": "0.34.0",
84+
"tslib": "1.9.3",
85+
"tslint": "5.12.1",
86+
"typescript": "3.2.4",
87+
"zone.js": "0.8.28"
8788
}
8889
}

packages/example-app/.angular-cli.json

-55
This file was deleted.

packages/example-app/package.json

+11-40
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
"scripts": {
77
"ng": "ng",
88
"start": "ng serve",
9-
"build": "ng build",
10-
"test": "ng test",
11-
"lint": "ng lint",
9+
"build": "ng build --prod",
1210
"e2e": "ng e2e",
1311
"bootstrap": "npm-run-all bootstrap:*",
1412
"bootstrap:store": "npm explore @angular-redux/store -- npm run build",
@@ -19,48 +17,21 @@
1917
"node": ">=8"
2018
},
2119
"dependencies": {
22-
"@angular-redux/form": "10.0.0",
23-
"@angular-redux/router": "10.0.0",
24-
"@angular-redux/store": "10.0.0",
25-
"@angular/common": "^7.2.1",
26-
"@angular/compiler": "^7.2.1",
27-
"@angular/core": "^7.2.1",
28-
"@angular/forms": "^7.2.1",
29-
"@angular/http": "^7.2.1",
30-
"@angular/platform-browser": "^7.2.1",
31-
"@angular/platform-browser-dynamic": "^7.2.1",
32-
"@angular/router": "^7.2.1",
33-
"core-js": "^2.6.2",
34-
"flux-standard-action": "^2.0.3",
35-
"ramda": "^0.23.0",
36-
"redux": "^4.0.0",
37-
"redux-logger": "^3.0.1",
38-
"redux-observable": "^1.0.0",
39-
"rxjs": "^6.3.3",
40-
"tslib": "^1.9.3",
41-
"zone.js": "^0.8.27"
20+
"@angular-redux/form": "9.0.1",
21+
"@angular-redux/router": "9.0.0",
22+
"@angular-redux/store": "9.0.0",
23+
"core-js": "2.6.2",
24+
"flux-standard-action": "2.0.3",
25+
"ramda": "0.23.0",
26+
"redux-logger": "3.0.6",
27+
"redux-observable": "1.0.0"
4228
},
4329
"devDependencies": {
4430
"@angular-devkit/build-angular": "0.12.1",
45-
"@angular/cli": "^7.2.1",
46-
"@angular/compiler-cli": "^7.2.0",
31+
"@angular/cli": "7.2.2",
4732
"@angular/language-service": "7.2.0",
48-
"@types/jasmine": "~2.8.8",
49-
"@types/jasminewd2": "~2.0.3",
50-
"@types/node": "10.12.18",
5133
"@types/ramda": "0.24.18",
5234
"@types/redux-logger": "3.0.6",
53-
"codelyzer": "~4.5.0",
54-
"jasmine-core": "~2.99.1",
55-
"jasmine-spec-reporter": "~4.2.1",
56-
"karma": "~3.1.1",
57-
"karma-chrome-launcher": "~2.2.0",
58-
"karma-coverage-istanbul-reporter": "~2.0.1",
59-
"karma-jasmine": "~1.1.2",
60-
"karma-jasmine-html-reporter": "^0.2.2",
61-
"protractor": "~5.4.0",
62-
"ts-node": "~7.0.0",
63-
"tslint": "~5.11.0",
64-
"typescript": "3.2.2"
35+
"ts-node": "7.0.1"
6536
}
6637
}

packages/example-app/protractor.conf.js

-30
This file was deleted.

packages/example-app/src/app/component.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ <h1>
22
{{ title }}
33
</h1>
44
<nav>
5-
<a routerLink= "/elephants" routerLinkActive="active">Elephants</a>
5+
<a routerLink="/elephants" routerLinkActive="active">Elephants</a>
66
<a routerLink="/lions" routerLinkActive="active">Lions</a>
77
<a routerLink="/feedback" routerLinkActive="active">Feedback</a>
88
</nav>

packages/example-app/src/karma.conf.js

-31
This file was deleted.

packages/example-app/src/test.ts

-21
This file was deleted.

packages/example-app/src/tsconfig.json

-23
This file was deleted.

packages/example-app/src/tsconfig.spec.json

-9
This file was deleted.

0 commit comments

Comments
 (0)