fix(node:express): return 404 status code when partial can't be found #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a 200 status code would be sent when a partial couldn't be rendered.
|
I think I'd agree with logging that the partial couldn't be found, but we shouldn't need to use res.status(404), since res.send(404) does the same thing. |
It would return the correct response code, but we'd lose the 404.html template. |
|
Good point, I'll take a closer look at this a little later. |
DaftMonk
added a commit
that referenced
this pull request
Feb 13, 2014
fix(node:express): return 404 status code when partial can't be found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a 200 status code would be sent when a partial couldn't be rendered.