docs(deployment): instructions to deploy on gcloud app engine standard edition #2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awk34
requested changes
Jul 8, 2018
| Download and install [Google Cloud SDK](https://cloud.google.com/sdk/) | ||
| ## 2. Create GCP Project | ||
| ```bash | ||
| gcloud projects create PROJECT_ID |
There was a problem hiding this comment.
I'd mention that PROJECT_ID needs to be replaced with something else
|
|
||
| # Prequsites | ||
| ## 1. Google Cloud SDK | ||
| Download and install [Google Cloud SDK](https://cloud.google.com/sdk/) |
There was a problem hiding this comment.
Remove leading spaces so this text doesn't get put into a code block
| ## 3. Enable Billing | ||
| ```bash | ||
| gcloud alpha billing projects link my-project \ | ||
| --billing-account 0X0X0X-0X0X0X-0X0X0X |
There was a problem hiding this comment.
Explain where this code comes from, and perhaps post a direct link to the web page for enabling billing
| --billing-account 0X0X0X-0X0X0X-0X0X0X | ||
| ``` | ||
| ## 4. Create a MongoDB database | ||
| Create a MongoDB instance and obtain the uri and credentials |
There was a problem hiding this comment.
Perhaps add a link for creating a Mongo server
| GCloud App Engine supports only the newest version of Node.js 8 | ||
| ```javascript | ||
| "engines": { | ||
| "node": " =8.0", |
There was a problem hiding this comment.
" =8.0" should probably be ">=8.0"
|
|
||
| 2.1 create a 'app.yaml' file with the following contents | ||
|
|
||
| ```javascript |
| ``` | ||
| ## 2. Copy app.yaml to dist | ||
| ```bash | ||
| copy app.yaml dist |
rohita77
commented
Jul 8, 2018
Awk34
approved these changes
Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generator-angular-fullstack$ npm test)Instructions to deploy on Google Cloud App Engine's Standard environment