Skip to content

Fix ESLint errors #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2016
Merged

Fix ESLint errors #2158

merged 4 commits into from
Aug 19, 2016

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Aug 17, 2016

with fix enabled. Should automatically get rid of a lot of ESLint issues.

fixes #2157

@Awk34 Awk34 changed the title feat(gen:app): add eslint to the yo write stream Fix ESLint errors Aug 17, 2016
@Awk34 Awk34 force-pushed the gen-run-eslint-fix branch from 729f897 to 5023093 Compare August 17, 2016 17:35
@@ -1,5 +1,6 @@
'use strict';

import _ from 'lodash';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have previously needed to use import * as _ from 'lodash'; to avoid getting an error in typescript, should probably check this out.

@Awk34 Awk34 merged commit 9f98f7c into master Aug 19, 2016
@Awk34 Awk34 deleted the gen-run-eslint-fix branch September 1, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all out-of-the-box ESLint errors
2 participants