Skip to content

(fix:express): reorder static middleware #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2016
Merged

(fix:express): reorder static middleware #1925

merged 1 commit into from
May 24, 2016

Conversation

mhheise
Copy link
Contributor

@mhheise mhheise commented May 24, 2016

Fixes an upstream issue in express-session or express-sequelize-session
where static middleware requests:

  • Hit the session store,
  • Overwrite one another, and
  • Generate many new sessions.

Fixes #1668.

Fixes an upstream issue in express-session or express-sequelize-session
where static middleware requests:
- Hit the session store,
- Overwrite one another, and
- Generate many new sessions.
Fixes #1668.
@mhheise
Copy link
Contributor Author

mhheise commented May 24, 2016

Hi @Awk34: npm test completed successfully on my local build but looks to have failed the CI check. Do you have any insight or recommendations on how to correct the PR so that the build passes? Thanks!

@Awk34
Copy link
Member

Awk34 commented May 24, 2016

It was the E2E tests; sometimes they get mad. I'm rebuilding.

@Awk34 Awk34 merged commit 9da05c8 into angular-fullstack:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants