-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(client:util.urlParse): special treatment for IE #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client:util.urlParse): special treatment for IE #1523
Conversation
eadc372
to
f63a394
Compare
Wow, bizarre. You should add that SO link to the comment. |
f63a394
to
869b45b
Compare
Thanks, added. |
fix(client:util.urlParse): special treatment for IE
Unfortunately, this fix does not help me. isSameOrigin method returns false in ie. |
Herokuapp.com have not same port with origins |
console.log(url.hostname, o.hostname, url.port, o.port, url.protocol, o.protocol); i got:
|
So the ports sometimes don't match, I shall make more tests against the default 80 (for http) and 443 (for https) ports, and some randomly specified ports in IE. |
However, we've been using 80 port on production for quite a while and no related bug report from client (using IE9+) yet. Could you provide your browser version and OS version? |
One my friend using phone with OS winphone 8.1 and browser IE could not log in. I don't have a windows now, today evening I'll do a little investigation 😄 |
Interesting http://stackoverflow.com/questions/13167302/did-ie10-change-the-definition-of-window-location-port |
@peter-fu |
isSameOrigin
always returnsfalse
in IE, thus user is never able to login.Thanks to http://stackoverflow.com/a/13405933