Skip to content

fix(client:util.urlParse): special treatment for IE #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2015

Conversation

peter-fu
Copy link
Contributor

isSameOrigin always returns false in IE, thus user is never able to login.

IE doesn't populate all link properties when setting .href with a relative URL,
however .href will return an absolute URL which then can be used on itself
to populate these additional fields.

Thanks to http://stackoverflow.com/a/13405933

@peter-fu peter-fu force-pushed the cannot-login-using-ie branch from eadc372 to f63a394 Compare December 30, 2015 03:16
@Awk34
Copy link
Member

Awk34 commented Dec 30, 2015

Wow, bizarre. You should add that SO link to the comment.

@peter-fu peter-fu force-pushed the cannot-login-using-ie branch from f63a394 to 869b45b Compare December 30, 2015 05:12
@peter-fu
Copy link
Contributor Author

Thanks, added.

Awk34 added a commit that referenced this pull request Dec 30, 2015
fix(client:util.urlParse): special treatment for IE
@Awk34 Awk34 merged commit ebf9bc4 into angular-fullstack:canary Dec 30, 2015
@jackkum
Copy link

jackkum commented Feb 27, 2016

Unfortunately, this fix does not help me. isSameOrigin method returns false in ie.

@jackkum
Copy link

jackkum commented Feb 27, 2016

Herokuapp.com have not same port with origins

@jackkum
Copy link

jackkum commented Feb 27, 2016

console.log(url.hostname, o.hostname, url.port, o.port, url.protocol, o.protocol);

i got:

site.com site.com 80  http: http:

@peter-fu
Copy link
Contributor Author

So the ports sometimes don't match, I shall make more tests against the default 80 (for http) and 443 (for https) ports, and some randomly specified ports in IE.

@peter-fu
Copy link
Contributor Author

@jackkum

However, we've been using 80 port on production for quite a while and no related bug report from client (using IE9+) yet. Could you provide your browser version and OS version?

@jackkum
Copy link

jackkum commented Feb 29, 2016

@peter-fu

One my friend using phone with OS winphone 8.1 and browser IE could not log in.
I'm try log in with notebook with OS Win7 IE (unfortunately don't remember version 8 or 9)

I don't have a windows now, today evening I'll do a little investigation 😄

@jackkum
Copy link

jackkum commented Feb 29, 2016

@jackkum
Copy link

jackkum commented Feb 29, 2016

ie

@jackkum
Copy link

jackkum commented Feb 29, 2016

@peter-fu
Windows 7, IE11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants