feat(gen): Show version in console, add to .yo-rc.json #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,13 +31,16 @@ export default class Generator extends Base { | |||
| return { | |||
|
|
|||
| init: function () { | |||
| this.filters = {}; | |||
| this.filters = { | |||
| generatorVersion: version | |||
There was a problem hiding this comment.
We can use this.rootGeneratorVersion() instead of version.
|
And a rebase. |
Awk34
force-pushed
the
log-gen-version
branch
from
d7e79e4 to
ad38d9b
Compare
|
done |
|
Thanks |
|
One question, why not add it as a top level property, instead of putting it in filters? |
|
|
|
..oversight, I'll change |
Awk34
force-pushed
the
log-gen-version
branch
from
ad38d9b to
f56ab60
Compare
kingcody
added a commit
that referenced
this pull request
Sep 11, 2015
feat(gen): Show version in console, add to .yo-rc.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.