Skip to content

Adding Google Maps <script> tag? #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonh1000 opened this issue Sep 14, 2014 · 6 comments
Closed

Adding Google Maps <script> tag? #554

simonh1000 opened this issue Sep 14, 2014 · 6 comments

Comments

@simonh1000
Copy link

At present I'm manually adding a line to index.html, but was wondering whether there was a better, 'recommended' way?

@remicastaing
Copy link
Contributor

I was also wondering what is the right way to add bower_components/bootstrap/js/modal.js to index.html.

@kingcody
Copy link
Member

@simonh1000 I'm not familiar with the google maps script, its located at some CDN I presume? If so then what you're doing is most likely the best solution as you won't need to minify it, google maintains the versions(?), google will serve it (most likely) as fast as your server will, and they'll most likely offer it in HTTP or HTTPS. Unless you find a bower package for it and want to server the script, I would just stick with what you have.

Just my thoughts though...

@kingcody
Copy link
Member

@remicastaing are you using ui-bootstrap?

@remicastaing
Copy link
Contributor

I used the usual bootstrap stuff (http://getbootstrap.com/javascript/#modals) and put a login directive inside ;). I didn't want to have to had a modal controller.

@kingcody
Copy link
Member

@remicastaing in your Gruntfile under the wiredep config, remove: /bootstrap.js/, from the exclude array if you would like to have wiredep inject it into your app.

@remicastaing
Copy link
Contributor

@kingcody, thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants