Skip to content

Can you make bootstrap optional again #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CooleyGit opened this issue Jul 2, 2014 · 13 comments
Closed

Can you make bootstrap optional again #297

CooleyGit opened this issue Jul 2, 2014 · 13 comments

Comments

@CooleyGit
Copy link

No description provided.

@snowman-repos
Copy link

👍

@kosz
Copy link

kosz commented Jul 2, 2014

👍

And especially angular-bootstrap.

Made my own accordion with bootstrap + angular in some 30 minutes.
Then tried to get the same functionality out of angular-bootstrap. Some 5 hours later I decided to post a question on their git hub, on stackoverflow, and google groups.
One month later still no answer, even though it looks like it's a design flaw on their part.

Something like this should definitely be optional :)

@JaKXz
Copy link
Collaborator

JaKXz commented Jul 2, 2014

Could we get some more concrete reasons? I think that there are many more pros than cons to angular ui bootstrap. The accordion is not difficult imho to implement, I'm curious what your struggle was @kosz.

In the meantime you guys can just remove it manually.

@kosz
Copy link

kosz commented Jul 2, 2014

@JaKXz

First off, to stay on topic of this ticket, I think ( and correct me if i'm wrong ) that CooleyGit was referring to bootstrap itself, not to angular-bootstrap.

While I love bootstrap myself, if i were to speculate on why people would want this optional, is probably so they can use alternatives, such as Foundation and the new solution from google ( name escapes me at the moment ).

As for my own issue with angular-bootstrap. Yes the accordion is very easy to implement, but to customize ?

First off all templates are written in JavaScript. The easiest/most straight forward method to customize them, based on their docs is to include them in your HTML in a script tag, but when doing that you still need to copy paste the stub from javascript code ...

However the biggest turn off was this : angular-ui/bootstrap#2291 . Trying to access the toggleOpen method from my own code, so that I may have ONE little button that triggers the expand, not have it expand whenever i click anywhere on the header. The only way I was able to implement this properly was through this horrid code :

$scope.$parent.$parent.$$prevSibling.toggleOpen()

Maybe I'm missing something really obvious here, since all my attempts to solve this, using all their supplied mediums of getting help were ignored. I even got a badge on stackoverflow for asking the question : "Tumbleweed: Asked a question with no votes, no answers, no comments, and low views for a week." yaay >:

@CooleyGit
Copy link
Author

"In the meantime you guys can just remove it manually."
This was the first thing I did when I saw that it was no longer optional, now grunt keeps throwing an errors and wont start.

@kosz
Copy link

kosz commented Jul 2, 2014

@CooleyGit I think it would be helpful to provide some more details about this, such as the error message and the steps you took to remove it, this way it can get fixed, regardless of what decision is made about making it optional or not.

I actually wonder ... if you remove bootstrap ... what happens to angular-bootstrap?

@CooleyGit
Copy link
Author

So for a sanity check I re installer fullstack and then ran bower uninstall of angular-bootstrap. When I run grunt serve this is the output.

Running "serve" task

Running "clean:server" (clean) task
Cleaning .tmp...OK

Running "env:all" (env) task

Running "injector:sass" (injector) task
Missing option `template`, using `dest` as template instead
Injecting scss files (3 files)
>> Nothing changed

Running "concurrent:server" (concurrent) task

    Running "sass:server" (sass) task
    File .tmp/app/app.css created.

    Done, without errors.


    Execution Time (2014-07-02 21:49:50 UTC)
    loading tasks  24ms  ▇ 2%
    sass:server    1.3s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 98%
    Total 1.3s

Running "injector:scripts" (injector) task
Missing option `template`, using `dest` as template instead
Injecting js files (13 files)
>> Nothing changed

Running "injector:sass" (injector) task
Missing option `template`, using `dest` as template instead
Injecting scss files (3 files)
>> Nothing changed

Running "injector:css" (injector) task
Missing option `template`, using `dest` as template instead
>> Nothing changed

Running "bowerInstall:target" (bowerInstall) task
Warning: Cannot read property 'main' of undefined Use --force to continue.

Aborted due to warnings.


Execution Time (2014-07-02 21:49:50 UTC)
injector:sass        96ms  ▇▇▇▇▇▇▇ 5%
concurrent:server    1.5s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 84%
injector:css         86ms  ▇▇▇▇▇▇ 5%
bowerInstall:target  54ms  ▇▇▇▇ 3%
Total 1.8s

@DaftMonk
Copy link
Member

DaftMonk commented Jul 2, 2014

That $injector error you're getting is because you need to remove ui.bootstrap from the dependencies in your client/app/app.js

You also need to remove ui bootstrap from your karma.conf.js

@CooleyGit
Copy link
Author

Thanks for the quick responses everyone got it working now.
Incase anyone else has this problem the steps I took are below.

bower uninstall angular-bootstrap
bower uninstall bootstrap

remove reference to bootstrap in bower.json, karma.conf.js and app.js

This is a great project and am really excited to see how fast it is growing especially excited to see ui-router support. For some context about the original question. I think bootstrap is a great tool but not always the answer from a UI perspective, thats why I thought it was great as an option in previous builds. The first project I built with this stack I already had a scaffolding built for my app UI not using bootstrap so it was a lot easer to apply that UI to this "boilerplate". I think having it as an option would be great but it is easy enough to remove manually so no big deal just would be a nice to have.

Keep up the great work!!!!!

@snowman-repos
Copy link

We always use our own in-house framework so removing bootstrap is always the first thing I'll do

@DaftMonk
Copy link
Member

DaftMonk commented Jul 4, 2014

I've made a branch that makes bootstrap optional again, and it'll be in the next minor version.

@DaftMonk DaftMonk closed this as completed Jul 4, 2014
@CooleyGit
Copy link
Author

Thanks

@cereallarceny
Copy link

Seconded. Thanks @DaftMonk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants