-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Can you make bootstrap optional again #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👍 |
👍 And especially angular-bootstrap. Made my own accordion with bootstrap + angular in some 30 minutes. Something like this should definitely be optional :) |
Could we get some more concrete reasons? I think that there are many more pros than cons to angular ui bootstrap. The accordion is not difficult imho to implement, I'm curious what your struggle was @kosz. In the meantime you guys can just remove it manually. |
First off, to stay on topic of this ticket, I think ( and correct me if i'm wrong ) that CooleyGit was referring to bootstrap itself, not to angular-bootstrap. While I love bootstrap myself, if i were to speculate on why people would want this optional, is probably so they can use alternatives, such as Foundation and the new solution from google ( name escapes me at the moment ). As for my own issue with angular-bootstrap. Yes the accordion is very easy to implement, but to customize ? First off all templates are written in JavaScript. The easiest/most straight forward method to customize them, based on their docs is to include them in your HTML in a script tag, but when doing that you still need to copy paste the stub from javascript code ... However the biggest turn off was this : angular-ui/bootstrap#2291 . Trying to access the toggleOpen method from my own code, so that I may have ONE little button that triggers the expand, not have it expand whenever i click anywhere on the header. The only way I was able to implement this properly was through this horrid code :
Maybe I'm missing something really obvious here, since all my attempts to solve this, using all their supplied mediums of getting help were ignored. I even got a badge on stackoverflow for asking the question : "Tumbleweed: Asked a question with no votes, no answers, no comments, and low views for a week." yaay >: |
"In the meantime you guys can just remove it manually." |
@CooleyGit I think it would be helpful to provide some more details about this, such as the error message and the steps you took to remove it, this way it can get fixed, regardless of what decision is made about making it optional or not. I actually wonder ... if you remove bootstrap ... what happens to angular-bootstrap? |
So for a sanity check I re installer fullstack and then ran bower uninstall of angular-bootstrap. When I run grunt serve this is the output.
|
That $injector error you're getting is because you need to remove ui.bootstrap from the dependencies in your You also need to remove ui bootstrap from your karma.conf.js |
Thanks for the quick responses everyone got it working now. bower uninstall angular-bootstrap remove reference to bootstrap in bower.json, karma.conf.js and app.js This is a great project and am really excited to see how fast it is growing especially excited to see ui-router support. For some context about the original question. I think bootstrap is a great tool but not always the answer from a UI perspective, thats why I thought it was great as an option in previous builds. The first project I built with this stack I already had a scaffolding built for my app UI not using bootstrap so it was a lot easer to apply that UI to this "boilerplate". I think having it as an option would be great but it is easy enough to remove manually so no big deal just would be a nice to have. Keep up the great work!!!!! |
We always use our own in-house framework so removing bootstrap is always the first thing I'll do |
I've made a branch that makes bootstrap optional again, and it'll be in the next minor version. |
Thanks |
Seconded. Thanks @DaftMonk |
No description provided.
The text was updated successfully, but these errors were encountered: