Skip to content

factory generator #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
joshuacox opened this issue Dec 7, 2016 · 5 comments
Closed
1 task done

factory generator #2381

joshuacox opened this issue Dec 7, 2016 · 5 comments

Comments

@joshuacox
Copy link

joshuacox commented Dec 7, 2016

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.0
Node 6.9.1
npm 3.10.8
Operating System Arch linux
etc etc
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB MongoDB
Auth Y
etc etc

When I make a new project yo angular-fullstack factorytest, and then try to make a factory it fails:

yo angular-fullstack:factory products
(!) require('yeoman-generator').generators.Base is deprecated. Use require('yeoman-generator').Base directly
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module 'generator-ng-component/factory'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.resolve (internal/module.js:27:19)
    at child.compose (/usr/lib/node_modules/generator-angular-fullstack/generators/factory/index.js:7:94)
    at Object.<anonymous> (/usr/lib/node_modules/generator-angular-fullstack/node_modules/yeoman-generator/lib/base.js:439:23)
    at /usr/lib/node_modules/generator-angular-fullstack/node_modules/run-async/index.js:25:25
    at /usr/lib/node_modules/generator-angular-fullstack/node_modules/run-async/index.js:24:19
    at /usr/lib/node_modules/generator-angular-fullstack/node_modules/yeoman-generator/lib/base.js:440:9
    at runCallback (timers.js:637:20)
    at tryOnImmediate (timers.js:610:5)
    at processImmediate [as _immediateCallback] (timers.js:582:5)
$ npm list -g generator-angular-fullstack --depth=1
/home/user/.nvm/versions/node/v6.9.1/lib
`-- [email protected]

all other generators work fine:

$yo angular-fullstack:route products
? What module name would you like to use? factorytestApp.products
? Where would you like to create this route? client/app/
? What will the url of your route be? /products
   create client/app/products/products.routes.js
   create client/app/products/products.component.js
   create client/app/products/products.component.spec.js
   create client/app/products/products.pug
   create client/app/products/products.scss
$yo angular-fullstack:service products
In the parent of this component, you should now import this component and add it as a dependency:

    import ProductsComponent from './products/products.component';
    ...
    export angular.module('myParentModule', [ProductsComponent]);
? What module name would you like to use? factorytestApp.products
? Where would you like to create this service? client/app/
   create client/app/products/products.service.js
   create client/app/products/products.service.spec.js
$yo angular-fullstack:controller products
? What module name would you like to use? factorytestApp.products
? Where would you like to create this controller? client/app/
   create client/app/products/products.controller.js
   create client/app/products/products.controller.spec.js
@Awk34
Copy link
Member

Awk34 commented Dec 7, 2016

Hmm. List it out with a depth of 2. The latest version of the subgenerator is 1.0.5. Make sure you have that. If so, I'll have to investigate further.... Thanks for the report.

@Awk34
Copy link
Member

Awk34 commented Dec 7, 2016

Actually, I just checked. This is a confirmed bug.

@joshuacox
Copy link
Author

depth=2 did not reveal more on generator-angular-fullstack

$ npm list -g generator-angular-fullstack --depth=2
~/.nvm/versions/node/v6.9.1/lib
`-- [email protected]

and by subgenerator did you mean ng-component?

$ npm list -g generator-ng-component --depth=2
~/.nvm/versions/node/v6.9.1/lib
+-- [email protected]
| `-- [email protected]
`-- [email protected]

let me know if I can provide more info.

@Awk34
Copy link
Member

Awk34 commented Dec 7, 2016

Thanks. This is a bug with this generator, as I found out after I investigated.

@Awk34 Awk34 closed this as completed in b09cfe5 Dec 8, 2016
@CleverCodingLab
Copy link

use node v8.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants