Skip to content

V4.0.1 breaks on 'production' deployment due to devDep imports. (browser-sync, ansi-strip) #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
dhaazen opened this issue Aug 25, 2016 · 1 comment
Closed
1 task done

Comments

@dhaazen
Copy link

dhaazen commented Aug 25, 2016

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.0.1
Node 4.4.5
npm 3.10.5
Operating System OS X 10
Item Answer
Transpiler Babel
Markup HTML
CSS SCSS
Router ui-router
Client Tests Mocha
DB SQL
Auth N

V4.0.1 breaks on 'production' deployment due to devDep imports. (browser-sync, ansi-strip) in express.js

Fixed by moving the:

const stripAnsi = require('strip-ansi');
var browserSync = require('browser-sync').create();  

Dependencies which are only in devDeps. To within the:

if ('development' === env) {

block.

@Awk34
Copy link
Member

Awk34 commented Aug 25, 2016

See #2124

@Awk34 Awk34 closed this as completed Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants