Skip to content

Shouldn't controllers get injected in index.html on build? #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CodisRedding opened this issue Apr 16, 2014 · 6 comments
Closed

Shouldn't controllers get injected in index.html on build? #186

CodisRedding opened this issue Apr 16, 2014 · 6 comments
Labels
Milestone

Comments

@CodisRedding
Copy link

If I remove all the controllers from the index.html file I thought all controllers should be injected on build. Or if I add a new controller even.

<!-- build:js({.tmp,app}) scripts/scripts.js -->
        <!-- endbuild -->
@DaftMonk
Copy link
Member

Right now they're being injected by sub-generators, but I totally agree this should be handled by a grunt or gulp task, and I plan on adding that in the very near future.

@CodisRedding
Copy link
Author

ahh that's what it was. the sub-gen. as soon as I get a min I may fork and propose something. thanks man

@zfarrell
Copy link
Contributor

I have an implementation of this that works, although it's not the most elegant solution (I've intended to come back and improve it, but since it's working...). I quickly created a patch for this generator, seen here: https://github.com/zfarrell/generator-angular-fullstack/commit/074278518c06d37701c0b86918bd1bd71730e3d5

I didn't have much time to do it, so it's more of a proof of concept (and thus, no pull request). Let me know if you have any questions.

@DaftMonk
Copy link
Member

Thank you for posting that Zac! That just saved me a lot of time.

@DaftMonk
Copy link
Member

I've started some work on grunt script/css injection, as well as restructuring the app. Have a look here: #192

@JaKXz JaKXz added this to the 2.0.0 milestone Jun 1, 2014
@JaKXz JaKXz added the bug label Jun 1, 2014
@DaftMonk
Copy link
Member

DaftMonk commented Jul 3, 2014

Automatic injection is launched in 2.0

@DaftMonk DaftMonk closed this as completed Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants