Skip to content

Commit bf78a58

Browse files
committed
Merge branch 'master' of github.com:angular-fullstack/generator-angular-fullstack into canary
# Conflicts: # package.json # src/generators/app/index.js # templates/app/_package.json # templates/app/gulpfile.babel(gulp).js # templates/app/server/config/environment/production.js
2 parents dd485cb + 50e6d0c commit bf78a58

15 files changed

+61
-22
lines changed

Diff for: CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
<a name="3.7.6"></a>
2+
## [3.7.6](https://github.com/angular-fullstack/generator-angular-fullstack/compare/3.7.5...v3.7.6) (2016-06-21)
3+
4+
5+
### Notable Changes
6+
7+
* Add deprecation warning about Grunt
8+
* Bumped a few generator dependencies
9+
10+
11+
112
<a name="3.7.5"></a>
213
## [3.7.5](https://github.com/angular-fullstack/generator-angular-fullstack/compare/3.7.4...v3.7.5) (2016-06-02)
314

Diff for: docs/generators/app.md

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ Options:
1111
--skip-cache # Do not remember prompt answers Default: false
1212
--skip-install # Do not install dependencies Default: false
1313
--app-suffix # Allow a custom suffix to be added to the module name Default: App
14+
--dev-port # Port to use for the development HTTP server Default: 9000
15+
--debug-port # Port to use for the server debugger Default: 5858
16+
--prod-port # Port to use for the production HTTP Server Default: 8080
1417

1518
Arguments:
1619
name Type: String Required: false

Diff for: docs/index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Overview
110110
├── client
111111
│   ├── app - All of our app specific components go in here
112112
│   ├── assets - Custom assets: fonts, images, etc…
113-
│   ├── components - Our reusable components, non-specific to to our app
113+
│   ├── components - Our reusable components, non-specific to our app
114114
115115
├── e2e - Our protractor end to end tests
116116

Diff for: package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
"grunt-david": "~0.7.0",
6868
"grunt-env": "^0.4.1",
6969
"grunt-mocha-test": "^0.12.7",
70-
"grunt-release": "^0.13.0",
70+
"grunt-release": "^0.14.0",
7171
"gulp": "^3.9.1",
7272
"gulp-if": "^2.0.1",
7373
"gulp-mocha": "^2.2.0",
@@ -76,13 +76,13 @@
7676
"jit-grunt": "~0.10.0",
7777
"lazypipe": "^1.0.1",
7878
"merge-stream": "^1.0.0",
79-
"minimatch": "^3.0.0",
79+
"minimatch": "^3.0.2",
8080
"mocha": "^2.5.2",
8181
"q": "^1.0.1",
8282
"recursive-readdir": "^2.0.0",
8383
"run-sequence": "^1.2.1",
8484
"shelljs": "^0.7.0",
85-
"should": "^9.0.0",
85+
"should": "^9.0.2",
8686
"yeoman-assert": "^2.0.0",
8787
"yeoman-test": "~1.4.0"
8888
},

Diff for: readme.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ Install `yo`, `grunt-cli`/`gulp-cli`, `bower`, and `generator-angular-fullstack`
1919
npm install -g yo grunt-cli gulp-cli bower generator-angular-fullstack
2020
```
2121

22+
> To install the latest 4.0.0 Beta with Webpack support, use `generator-angular-fullstack@beta`
23+
2224
Make a new directory, and `cd` into it:
2325
```
2426
mkdir my-new-project && cd $_
@@ -40,7 +42,7 @@ Run `grunt`/`gulp build` for building, `grunt serve`/`gulp serve` for developmen
4042

4143
**General**
4244

43-
* Build Systems: `Grunt`, `Gulp`
45+
* Build Systems: `Grunt` (deprecated, will be removed in 4.0.0), `Gulp`
4446
* Testing:
4547
* `Jasmine`
4648
* `Mocha + Chai + Sinon`

Diff for: src/generators/app/index.js

+24-3
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,24 @@ export class Generator extends Base {
3838
type: String,
3939
defaults: 'App'
4040
});
41+
42+
this.option('dev-port', {
43+
desc: 'Port to use for the development HTTP server',
44+
type: String,
45+
defaults: '9000'
46+
});
47+
48+
this.option('debug-port', {
49+
desc: 'Port to use for the server debugger',
50+
type: String,
51+
defaults: '5858'
52+
});
53+
54+
this.option('prod-port', {
55+
desc: 'Port to use for the production HTTP Server',
56+
type: String,
57+
defaults: '8080'
58+
});
4159
}
4260

4361
get initializing() {
@@ -308,9 +326,12 @@ export class Generator extends Base {
308326
type: 'list',
309327
name: 'buildtool',
310328
message: 'Would you like to use Gulp or Grunt?',
311-
choices: ['Grunt', 'Gulp'],
312-
default: 1,
313-
filter: val => val.toLowerCase()
329+
choices: ['Gulp', 'Grunt (deprecated)'],
330+
default: 0,
331+
filter: val => ({
332+
'Gulp': 'gulp',
333+
'Grunt (deprecated)': 'grunt'
334+
})[val]
314335
}, {
315336
type: 'list',
316337
name: 'testing',

Diff for: templates/app/Gruntfile(grunt).js

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module.exports = function(grunt) {
3636
},
3737
express: {
3838
options: {
39-
port: process.env.PORT || 9000
39+
port: process.env.PORT || <%= devPort %>
4040
},
4141
dev: {
4242
options: {
@@ -239,7 +239,7 @@ module.exports = function(grunt) {
239239
options: {
240240
nodeArgs: ['--debug-brk'],
241241
env: {
242-
PORT: process.env.PORT || 9000
242+
PORT: process.env.PORT || <%= devPort %>
243243
},
244244
callback: function(nodemon) {
245245
nodemon.on('log', function(event) {
@@ -249,7 +249,7 @@ module.exports = function(grunt) {
249249
// opens browser on initial server start
250250
nodemon.on('config:update', function() {
251251
setTimeout(function() {
252-
require('open')('http://localhost:8080/debug?port=5858');
252+
require('open')('http://localhost:<%= devPort %>/debug?port=<%= debugPort %>');
253253
}, 500);
254254
});
255255
}

Diff for: templates/app/_package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"ejs": "^2.3.3",<% } %><% if(filters.mongoose) { %>
3939
"mongoose": "^4.1.2",
4040
"bluebird": "^3.3.3",
41-
"connect-mongo": "^1.1.0",<% } %><% if(filters.sequelize) { %>
41+
"connect-mongo": "^1.2.1",<% } %><% if(filters.sequelize) { %>
4242
"sequelize": "^3.5.1",
4343
"sqlite3": "~3.1.1",
4444
"express-sequelize-session": "0.4.0",<% } %><% if(filters.auth) { %>
@@ -76,7 +76,7 @@
7676
"del": "^2.0.2",
7777
"gulp": "^3.9.1",
7878
"gulp-add-src": "^0.2.0",
79-
"gulp-angular-templatecache": "^1.7.0",
79+
"gulp-angular-templatecache": "^2.0.0",
8080
"gulp-autoprefixer": "^3.1.0",
8181
"gulp-babel": "^6.1.2",<% if(filters.ts) { %>
8282
"gulp-typescript": "~2.13.0",

Diff for: templates/app/gulpfile.babel(gulp).js

+5-3
Original file line numberDiff line numberDiff line change
@@ -353,13 +353,15 @@ gulp.task('start:server:prod', () => {
353353

354354
gulp.task('start:inspector', () => {
355355
gulp.src([])
356-
.pipe(plugins.nodeInspector());
356+
.pipe(plugins.nodeInspector({
357+
debugPort: <%= debugPort %>
358+
}));
357359
});
358360

359361
gulp.task('start:server:debug', () => {
360362
process.env.NODE_ENV = process.env.NODE_ENV || 'development';
361-
config = require(`./${serverPath}/config/environment`);
362-
nodemon(`-w ${serverPath} --debug-brk ${serverPath}`)
363+
config = require(`./${serverPath}/config/environment`);
364+
nodemon(`-w ${serverPath} --debug=<%= debugPort %> --debug-brk ${serverPath}`)
363365
.on('log', onServerLog);
364366
});
365367

Diff for: templates/app/karma.conf.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ module.exports = function(config) {
6767
exclude: [],
6868

6969
// web server port
70-
port: 8080,
70+
port: <%= devPort %>,
7171

7272
// level of logging
7373
// possible values: LOG_DISABLE || LOG_ERROR || LOG_WARN || LOG_INFO || LOG_DEBUG

Diff for: templates/app/protractor.conf.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var config = {
1010

1111
// A base URL for your application under test. Calls to protractor.get()
1212
// with relative paths will be prepended with this.
13-
baseUrl: 'http://localhost:' + (process.env.PORT || '9000'),
13+
baseUrl: 'http://localhost:' + (process.env.PORT || '<%= devPort %>'),
1414

1515
// Credientials for Saucelabs
1616
sauceUser: process.env.SAUCE_USERNAME,

Diff for: templates/app/server/config/_local.env.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// You will need to set these on the server you deploy to.
77

88
module.exports = {
9-
DOMAIN: 'http://localhost:9000',
9+
DOMAIN: 'http://localhost:<%= devPort %>',
1010
SESSION_SECRET: '<%= lodash.slugify(appname) + "-secret" %>',<% if (filters.facebookAuth) { %>
1111

1212
FACEBOOK_ID: 'app-id',

Diff for: templates/app/server/config/_local.env.sample.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// You will need to set these on the server you deploy to.
77

88
module.exports = {
9-
DOMAIN: 'http://localhost:9000',
9+
DOMAIN: 'http://localhost:<%= devPort %>',
1010
SESSION_SECRET: '<%= lodash.slugify(appname) + "-secret" %>',<% if (filters.facebookAuth) { %>
1111

1212
FACEBOOK_ID: 'app-id',

Diff for: templates/app/server/config/environment/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var all = {
2020
root: path.normalize(`${__dirname}/../../..`),
2121

2222
// Server port
23-
port: process.env.PORT || 9000,
23+
port: process.env.PORT || <%= devPort %>,
2424

2525
// Server IP
2626
ip: process.env.IP || '0.0.0.0',

Diff for: templates/app/server/config/environment/production.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = {
1212
// Server port
1313
port: process.env.OPENSHIFT_NODEJS_PORT
1414
|| process.env.port
15-
|| 8080<% if (filters.mongoose) { %>,
15+
|| <%= prodPort %><% if(filters.mongoose) { %>,
1616

1717
// MongoDB connection options
1818
mongo: {

0 commit comments

Comments
 (0)