Skip to content

Commit 71f8a08

Browse files
committed
Merge branch 'master' of github.com:angular-fullstack/generator-angular-fullstack into canary
Conflicts: package.json templates/app/server/api/user(auth)/user.model(mongooseModels).js
2 parents 69933c6 + b4731c1 commit 71f8a08

File tree

5 files changed

+31
-15
lines changed

5 files changed

+31
-15
lines changed

Diff for: PULL_REQUEST_TEMPLATE.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
- [ ] I have read the [Contributing Documents](https://github.com/DaftMonk/generator-angular-fullstack/blob/master/contributing.md)
2-
- [ ] My commit(s) follow the [AngularJS commit message guidelines](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/)
2+
- [ ] My commit(s) follow the [AngularJS commit message guidelines](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/)
3+
- [ ] The generator's tests pass (`generator-angular-fullstack$ npm test`)

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
"q": "^1.0.1",
8181
"recursive-readdir": "^2.0.0",
8282
"run-sequence": "^1.1.5",
83-
"shelljs": "^0.6.0",
83+
"shelljs": "^0.7.0",
8484
"should": "^8.3.1",
8585
"yeoman-assert": "^2.0.0",
8686
"yeoman-test": "~1.4.0"

Diff for: templates/app/_package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
"grunt-nodemon": "^0.4.0",
128128
"grunt-angular-templates": "^1.0.3",
129129
"grunt-dom-munger": "^3.4.0",
130-
"grunt-protractor-runner": "^2.0.0",
130+
"grunt-protractor-runner": "^3.1.0",
131131
"grunt-injector": "^0.6.0",
132132
"grunt-karma": "~0.12.0",
133133
"grunt-build-control": "^0.7.0",<% if(filters.sass) { %>
@@ -155,8 +155,8 @@
155155
"karma-requirejs": "~0.2.2",
156156
"karma-jade-preprocessor": "0.0.11",
157157
"karma-phantomjs-launcher": "~1.0.0",<% if (filters.jade) { %>
158-
"karma-ng-jade2js-preprocessor": "^0.2.0",<% } else { %>
159-
"karma-ng-html2js-preprocessor": "~0.2.0",<% } %>
158+
"karma-ng-jade2js-preprocessor": "^0.2.0",<% } %>
159+
"karma-ng-html2js-preprocessor": "~0.2.0",
160160
"karma-spec-reporter": "~0.0.20",
161161
"sinon-chai": "^2.8.0",
162162
"mocha": "^2.2.5",<% if (filters.mocha) { %>

Diff for: templates/app/client/tslint.json(ts)

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"no-debugger": true,
2222
"no-duplicate-key": true,
2323
"no-duplicate-variable": true,
24-
"no-empty": true,
2524
"no-eval": true,
2625
"no-inferrable-types": true,
2726
"no-shadowed-variable": true,

Diff for: templates/app/gulpfile.babel(gulp).js

+25-9
Original file line numberDiff line numberDiff line change
@@ -227,15 +227,11 @@ gulp.task('inject:js', () => {
227227
.pipe(gulp.dest(clientPath));
228228
});<% if(filters.ts) { %>
229229

230-
gulp.task('inject:tsconfig', () => {
231-
let src = gulp.src([
232-
`${clientPath}/**/!(*.spec|*.mock).ts`,
233-
`!${clientPath}/bower_components/**/*`,
234-
`${clientPath}/typings/**/*.d.ts`
235-
], {read: false})
230+
function injectTsConfig(filesGlob, tsconfigPath){
231+
let src = gulp.src(filesGlob, {read: false})
236232
.pipe(plugins.sort());
237233

238-
return gulp.src('./tsconfig.client.json')
234+
return gulp.src(tsconfigPath)
239235
.pipe(plugins.inject(src, {
240236
starttag: '"files": [',
241237
endtag: ']',
@@ -244,6 +240,26 @@ gulp.task('inject:tsconfig', () => {
244240
}
245241
}))
246242
.pipe(gulp.dest('./'));
243+
}
244+
245+
gulp.task('inject:tsconfig', () => {
246+
return injectTsConfig([
247+
`${clientPath}/**/!(*.spec|*.mock).ts`,
248+
`!${clientPath}/bower_components/**/*`,
249+
`${clientPath}/typings/**/*.d.ts`,
250+
`!${clientPath}/test_typings/**/*.d.ts`
251+
],
252+
'./tsconfig.client.json');
253+
});
254+
255+
gulp.task('inject:tsconfigTest', () => {
256+
return injectTsConfig([
257+
`${clientPath}/**/+(*.spec|*.mock).ts`,
258+
`!${clientPath}/bower_components/**/*`,
259+
`!${clientPath}/typings/**/*.d.ts`,
260+
`${clientPath}/test_typings/**/*.d.ts`
261+
],
262+
'./tsconfig.client.test.json');
247263
});<% } %>
248264

249265
gulp.task('inject:css', () => {
@@ -305,12 +321,12 @@ gulp.task('styles', () => {
305321
.pipe(gulp.dest('.tmp/app'));
306322
});<% if(filters.ts) { %>
307323

308-
gulp.task('copy:constant', () => {
324+
gulp.task('copy:constant', ['constant'], () => {
309325
return gulp.src(`${clientPath}/app/app.constant.js`, { dot: true })
310326
.pipe(gulp.dest('.tmp/app'));
311327
})
312328

313-
gulp.task('transpile:client', ['tsd', 'constant', 'copy:constant'], () => {
329+
gulp.task('transpile:client', ['tsd', 'copy:constant'], () => {
314330
let tsProject = plugins.typescript.createProject('./tsconfig.client.json');
315331
return tsProject.src()
316332
.pipe(plugins.sourcemaps.init())

0 commit comments

Comments
 (0)