Skip to content

Commit 70bf985

Browse files
committed
feat(gen): remove gulp flag, add build tool project prompt
1 parent 661ec3a commit 70bf985

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

Diff for: app/generator.js

+4-13
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,6 @@ export default class Generator extends Base {
1919
defaults: false
2020
});
2121

22-
this.option('gulp', {
23-
desc: 'Use experimental Gulp configuration',
24-
type: Boolean,
25-
defaults: false
26-
});
27-
2822
this.option('app-suffix', {
2923
desc: 'Allow a custom suffix to be added to the module name',
3024
type: String,
@@ -266,14 +260,14 @@ export default class Generator extends Base {
266260

267261
this.log('\n# Project\n');
268262

269-
this.prompt([/*{
263+
this.prompt([{
270264
type: 'list',
271265
name: 'buildtool',
272-
message: 'Would you like to use Gulp (experimental) instead of Grunt?',
266+
message: 'Would you like to use Gulp or Grunt?',
273267
choices: ['Grunt', 'Gulp'],
274268
default: 0,
275269
filter: val => val.toLowerCase()
276-
}, */{
270+
}, {
277271
type: 'list',
278272
name: 'testing',
279273
message: 'What would you like to write tests with?',
@@ -298,10 +292,7 @@ export default class Generator extends Base {
298292
return answers.testing === 'mocha';
299293
}
300294
}], function (answers) {
301-
this.filters.grunt = !this.options['gulp'];
302-
this.filters.gulp = !!this.options['gulp'];
303-
// this.filters.grunt = answers.buildtool === 'grunt';
304-
// this.filters.gulp = answers.buildtool === 'gulp';
295+
this.filters[answers.buildtool] = true;
305296

306297
this.filters[answers.testing] = true;
307298
if (answers.testing === 'mocha') {

Diff for: readme.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Run `grunt` for building, `grunt serve` for preview, and `grunt serve:dist` for
4141

4242
**General**
4343

44-
* Build Systems: `Grunt`, `Gulp` (experimental)
44+
* Build Systems: `Grunt`, `Gulp`
4545
* Testing:
4646
* `Jasmine`
4747
* `Mocha + Chai + Sinon`
@@ -113,7 +113,6 @@ Options:
113113
--skip-cache # Do not remember prompt answers Default: false
114114
--skip-install # Do not install dependencies Default: false
115115
--app-suffix # Allow a custom suffix to be added to the module name Default: App
116-
--gulp # Use the experimental Gulp config instead of Grunt Default: false
117116

118117
Arguments:
119118
name Type: String Required: false

0 commit comments

Comments
 (0)