Skip to content

Commit 68c6e39

Browse files
committed
fix(css): refactor CSS handling
1 parent 3ce0fa2 commit 68c6e39

File tree

7 files changed

+50
-39
lines changed

7 files changed

+50
-39
lines changed

Diff for: templates/app/_package.json

+1
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@
176176
"stylus": "^0.54.5",
177177
"stylus-loader": "^3.0.1",<% } %>
178178
"karma-webpack": "^2.0.3",
179+
"to-string-loader": "^1.1.5",
179180
<%# END WEBPACK %>
180181
"through2": "^2.0.1",
181182
"open": "~0.0.4",

Diff for: templates/app/client/app/app(css).css

-9
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,3 @@
5555
[hidden] {
5656
display: none !important;
5757
}
58-
59-
/* Component styles are injected through gulp */
60-
/* inject:css */
61-
@import 'admin/admin.css';
62-
@import 'main/main.css';
63-
@import '../components/footer/footer.css';
64-
@import '../components/modal/modal.css';
65-
@import '../components/oauth-buttons/oauth-buttons.css';
66-
/* endinject */

Diff for: templates/app/client/app/app(less).less

-5
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,3 @@
2727
[hidden] {
2828
display: none !important;
2929
}
30-
31-
/* inject:less */
32-
@import 'admin/admin.less';
33-
@import 'main/main.less';
34-
/* endinject */

Diff for: templates/app/client/app/app(sass).scss

-2
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,3 @@ $fa-font-path: '/assets/fonts/font-awesome/';
3838
.ng-invalid:not(form) {
3939
border-left: 5px solid #a94442; /* red */
4040
}
41-
42-
@import 'admin/admin.scss';

Diff for: templates/app/client/app/app(stylus).styl

+2-8
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
$fa-font-path = '../assets/fonts/font-awesome/'
2-
@import '~font-awesome-stylus/stylus/index'
2+
@import '~font-awesome-stylus/lib/font-awesome-stylus/index'
33

44
<%_ if (filters.bootstrap) { %>
55
$icon-font-path = '../assets/fonts/bootstrap/'
6-
@import '~bootstrap-styl/bootstrap/index';
6+
@import '~bootstrap/dist/css/bootstrap.css'
77
<% if (filters.oauth) { %>@import '~bootstrap-social/bootstrap-social.css'
88
<% } %><% } %>
99

@@ -25,9 +25,3 @@ $icon-font-path = '../assets/fonts/bootstrap/'
2525

2626
[hidden]
2727
display: none !important
28-
29-
// Component styles are injected through gulp
30-
/* inject:styl */
31-
@import "admin/admin"
32-
@import "main/main"
33-
/* endinject */

Diff for: templates/app/client/app/app.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'style-loader!./app.<%= styleExt %>';
1+
import './app.<%= styleExt %>';
22

33
import './polyfills';
44

Diff for: templates/app/webpack.make.js

+46-14
Original file line numberDiff line numberDiff line change
@@ -192,38 +192,70 @@ module.exports = function makeWebpackConfig(options) {
192192
// Reference: https://github.com/postcss/postcss-loader
193193
// Postprocess your css with PostCSS plugins
194194
test: /\.css$/,
195-
use: ['raw-loader', 'css-loader', 'postcss-loader'],
195+
use: ['style-loader', 'css-loader', 'postcss-loader'],
196196
include: [
197-
path.resolve(__dirname, 'client')
197+
path.resolve(__dirname, 'node_modules/bootstrap/dist/css/*.css'),
198+
path.resolve(__dirname, 'client/app/app.css')
198199
]
199-
}<% if(!filters.css) { %>, {
200-
<%_ if(filters.sass) { _%>
200+
}<%_ if(filters.css) { _%>, {
201+
// CSS LOADER
202+
// Reference: https://github.com/webpack/css-loader
203+
test: /\.css$/,
204+
use: ['to-string-loader', 'css-loader?sourceMap', 'postcss-loader'],
205+
include: [
206+
path.resolve(__dirname, 'client')
207+
],
208+
exclude: [/app\.css$/]
209+
}<%_ } else if(filters.sass) { _%>, {
201210
// SASS LOADER
202211
// Reference: https://github.com/jtangelder/sass-loader
203212
test: /\.(scss|sass)$/,
204-
use: ['raw-loader', 'sass-loader'],
213+
use: ['style-loader', 'css-loader?sourceMap', 'sass-loader'],
205214
include: [
206215
path.resolve(__dirname, 'node_modules/bootstrap-sass/assets/stylesheets/*.scss'),
216+
path.resolve(__dirname, 'client/app/app.scss')
217+
]
218+
}, {
219+
// SASS LOADER
220+
// Reference: https://github.com/jtangelder/sass-loader
221+
test: /\.(scss|sass)$/,
222+
use: ['to-string-loader?sourceMap', 'css-loader?sourceMap', 'sass-loader?sourceMap'],
223+
include: [
207224
path.resolve(__dirname, 'client')
208-
]<% } %>
209-
<%_ if(filters.less) { _%>
225+
],
226+
exclude: [/app\.scss$/]
227+
}<% } else if(filters.less) { %>, {
210228
// LESS LOADER
211-
// Reference: https://github.com/
212229
test: /\.less$/,
213-
use: ['raw-loader', 'less-loader'],
230+
use: ['style-loader', 'css-loader?sourceMap', 'less-loader'],
214231
include: [
215232
path.resolve(__dirname, 'node_modules/bootstrap/less/*.less'),
233+
path.resolve(__dirname, 'client/app/app.less')
234+
]
235+
}, {
236+
// LESS LOADER
237+
test: /\.less$/,
238+
use: ['to-string-loader?sourceMap', 'css-loader?sourceMap', 'less-loader'],
239+
include: [
216240
path.resolve(__dirname, 'client')
217-
]<% } %>
218-
<%_ if(filters.stylus) { _%>
241+
],
242+
exclude: [/app\.less$/]
243+
}<% } else if(filters.stylus) { %>, {
219244
// Stylus LOADER
220-
// Reference: https://github.com/
221245
test: /\.styl$/,
222-
use: ['raw-loader', 'stylus-loader'],
246+
use: ['style-loader', 'css-loader?sourceMap', 'stylus-loader'],
223247
include: [
224248
path.resolve(__dirname, 'node_modules/bootstrap-styl/bootstrap/*.styl'),
249+
path.resolve(__dirname, 'client/app/app.styl')
250+
]
251+
}, {
252+
// Stylus LOADER
253+
test: /\.styl$/,
254+
use: ['to-string-loader?sourceMap', 'css-loader?sourceMap', 'stylus-loader'],
255+
include: [
225256
path.resolve(__dirname, 'client')
226-
]<% } %>
257+
],
258+
exclude: [/app\.styl$/]
227259
}<% } %>]
228260
};
229261

0 commit comments

Comments
 (0)