Skip to content

Commit 5a48c44

Browse files
committed
Merge pull request #490 from eddiemonge/fix484
fix(app): services use classified names
2 parents a358c1a + 56a71a8 commit 5a48c44

File tree

6 files changed

+27
-22
lines changed

6 files changed

+27
-22
lines changed

Diff for: script-base.js

+5
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,11 @@ Generator.prototype.addScriptToIndex = function (script) {
106106
};
107107

108108
Generator.prototype.generateSourceAndTest = function (appTemplate, testTemplate, targetDirectory, skipAdd) {
109+
// Services use classified names
110+
if (this.generatorName.toLowerCase() === 'service') {
111+
this.cameledName = this.classedName;
112+
}
113+
109114
this.appTemplate(appTemplate, path.join('scripts', targetDirectory, this.name));
110115
this.testTemplate(testTemplate, path.join(targetDirectory, this.name));
111116
if (!skipAdd) {

Diff for: templates/coffeescript-min/spec/service.coffee

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
'use strict'
22

3-
describe 'Service: <%= classedName %>', () ->
3+
describe 'Service: <%= cameledName %>', () ->
44

55
# load the service's module
66
beforeEach module '<%= scriptAppName %>'
77

88
# instantiate service
9-
<%= classedName %> = {}
10-
beforeEach inject (_<%= classedName %>_) ->
11-
<%= classedName %> = _<%= classedName %>_
9+
<%= cameledName %> = {}
10+
beforeEach inject (_<%= cameledName %>_) ->
11+
<%= cameledName %> = _<%= cameledName %>_
1212

1313
it 'should do something', () ->
14-
expect(!!<%= classedName %>).toBe true
14+
expect(!!<%= cameledName %>).toBe true

Diff for: templates/coffeescript/spec/service.coffee

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
'use strict'
22

3-
describe 'Service: <%= classedName %>', () ->
3+
describe 'Service: <%= cameledName %>', () ->
44

55
# load the service's module
66
beforeEach module '<%= scriptAppName %>'
77

88
# instantiate service
9-
<%= classedName %> = {}
10-
beforeEach inject (_<%= classedName %>_) ->
11-
<%= classedName %> = _<%= classedName %>_
9+
<%= cameledName %> = {}
10+
beforeEach inject (_<%= cameledName %>_) ->
11+
<%= cameledName %> = _<%= cameledName %>_
1212

1313
it 'should do something', () ->
14-
expect(!!<%= classedName %>).toBe true
14+
expect(!!<%= cameledName %>).toBe true

Diff for: templates/javascript-min/spec/service.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
'use strict';
22

3-
describe('Service: <%= classedName %>', function () {
3+
describe('Service: <%= cameledName %>', function () {
44

55
// load the service's module
66
beforeEach(module('<%= scriptAppName %>'));
77

88
// instantiate service
9-
var <%= classedName %>;
10-
beforeEach(inject(function(_<%= classedName %>_) {
11-
<%= classedName %> = _<%= classedName %>_;
9+
var <%= cameledName %>;
10+
beforeEach(inject(function(_<%= cameledName %>_) {
11+
<%= cameledName %> = _<%= cameledName %>_;
1212
}));
1313

1414
it('should do something', function () {
15-
expect(!!<%= classedName %>).toBe(true);
15+
expect(!!<%= cameledName %>).toBe(true);
1616
});
1717

1818
});

Diff for: templates/javascript/spec/service.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
'use strict';
22

3-
describe('Service: <%= classedName %>', function () {
3+
describe('Service: <%= cameledName %>', function () {
44

55
// load the service's module
66
beforeEach(module('<%= scriptAppName %>'));
77

88
// instantiate service
9-
var <%= classedName %>;
10-
beforeEach(inject(function (_<%= classedName %>_) {
11-
<%= classedName %> = _<%= classedName %>_;
9+
var <%= cameledName %>;
10+
beforeEach(inject(function (_<%= cameledName %>_) {
11+
<%= cameledName %> = _<%= cameledName %>_;
1212
}));
1313

1414
it('should do something', function () {
15-
expect(!!<%= classedName %>).toBe(true);
15+
expect(!!<%= cameledName %>).toBe(true);
1616
});
1717

1818
});

Diff for: test/test-file-creation.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ describe('Angular generator', function () {
167167

168168
describe('Service', function () {
169169
function serviceTest (generatorType, nameFn, done) {
170-
generatorTest(generatorType, 'service', 'services', nameFn, _.classify, '', done);
171-
};
170+
generatorTest(generatorType, 'service', 'services', nameFn, nameFn, '', done);
171+
}
172172

173173
it('should generate a new constant', function (done) {
174174
serviceTest('constant', _.camelize, done);

0 commit comments

Comments
 (0)