Skip to content

Commit 4139694

Browse files
committed
fix(gulp): build images before rev-replace
When running `gulp build` the rev manifest will be remade, but the task "build:client" which uses this file doesn't depend on "build:images" which populates this file. The result is that when running `build`, rev-replace will be unable to replace images as it doesn't wait for images to be filled in. Solution is to simply have "build:client" depend upon "build:images"
1 parent e74acdd commit 4139694

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: app/templates/gulpfile.babel(gulp).js

+1-1
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ gulp.task('build', cb => {
561561

562562
gulp.task('clean:dist', () => del([`${paths.dist}/!(.git*|.openshift|Procfile)**`], {dot: true}));
563563

564-
gulp.task('build:client', ['transpile:client', 'styles', 'html', 'constant'], () => {
564+
gulp.task('build:client', ['transpile:client', 'styles', 'html', 'constant', 'build:images'], () => {
565565
var manifest = gulp.src(`${paths.dist}/${clientPath}/assets/rev-manifest.json`);
566566

567567
var appFilter = plugins.filter('**/app.js', {restore: true});

0 commit comments

Comments
 (0)