Skip to content

Commit 2e784bf

Browse files
committed
fix(seed): rename index.html to app.html to fix CRSF and token issues
1 parent 113b7e6 commit 2e784bf

File tree

9 files changed

+14
-14
lines changed

9 files changed

+14
-14
lines changed

Diff for: docs/content/developing/index.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ Time: 16538ms
7575
app.bundle.js.map 3.34 MB 0 [emitted] app
7676
polyfills.bundle.js.map 271 kB 1 [emitted] polyfills
7777
vendor.bundle.js.map 3.06 MB 2 [emitted] vendor
78-
../client/index.html 1.39 kB [emitted]
79-
Child html-webpack-plugin for "..\client\index.html":
78+
../client/app.html 1.39 kB [emitted]
79+
Child html-webpack-plugin for "..\client\app.html":
8080
Asset Size Chunks Chunk Names
81-
../client/index.html 2.69 kB 0
81+
../client/app.html 2.69 kB 0
8282
webpack: bundle is now VALID.
8383
```
8484

Diff for: docs/content/get-started/overview.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ webpack.make.js // main file for Webpack configuration
3535
```
3636
│ .eslintrc // eslint config for client files
3737
│ polyfills.js // imports of polyfills
38-
_index.html // template for the root HTML file of your app
38+
app.template.html // template for the root HTML file of your app
3939
4040
├───app
4141
│ │ app.config.js // contains app-wide configuration code

Diff for: src/test/get-expected-files.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export function app(options) {
4949
'client/.htaccess',
5050
'client/favicon.ico',
5151
'client/robots.txt',
52-
'client/_index.html',
52+
'client/app.template.html',
5353
`client/polyfills.${script}`,
5454
'client/app/app.' + script,
5555
'client/app/app.config.' + script,

Diff for: templates/app/_.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ public
44
.sass-cache<% } %>
55
.idea
66
client/bower_components
7-
client/index.html
7+
client/app.html
88
dist
99
/server/config/local.env.js
1010
npm-debug.log
File renamed without changes.

Diff for: templates/app/gulpfile.babel.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const paths = {
3636
styles: [`${clientPath}/{app,components}/**/*.<%= styleExt %>`],
3737
mainStyle: `${clientPath}/app/app.<%= styleExt %>`,
3838
views: `${clientPath}/{app,components}/**/*.<%= templateExt %>`,
39-
mainView: `${clientPath}/index.html`,
39+
mainView: `${clientPath}/app.html`,
4040
test: [`${clientPath}/{app,components}/**/*.{spec,mock}.<%= scriptExt %>`],
4141
e2e: ['e2e/**/*.spec.js']
4242
},

Diff for: templates/app/server/config/seed(models).js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default function seedDatabaseIfNeeded() {
3131
name: 'Smart Build System',
3232
info: 'Build system ignores `spec` files, allowing you to keep '
3333
+ 'tests alongside code. Automatic injection of scripts and '
34-
+ 'styles into your index.html'
34+
+ 'styles into your app.html'
3535
}, {
3636
name: 'Modular Structure',
3737
info: 'Best practice client and server structures allow for more '

Diff for: templates/app/server/routes.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ export default function(app) {
1717
app.route('/:url(api|auth|components|app|bower_components|assets)/*')
1818
.get(errors[404]);
1919

20-
// All other routes should redirect to the index.html
20+
// All other routes should redirect to the app.html
2121
app.route('/*')
2222
.get((req, res) => {
23-
res.sendFile(path.resolve(app.get('appPath') + '/index.html'));
23+
res.sendFile(path.resolve(app.get('appPath') + '/app.html'));
2424
});
2525
}

Diff for: templates/app/webpack.make.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -318,13 +318,13 @@ module.exports = function makeWebpackConfig(options) {
318318
}));
319319
}
320320

321-
// Skip rendering index.html in test mode
321+
// Skip rendering app.html in test mode
322322
// Reference: https://github.com/ampedandwired/html-webpack-plugin
323-
// Render index.html
323+
// Render app.html
324324
if(!TEST) {
325325
let htmlConfig = {
326-
template: 'client/_index.html',
327-
filename: '../client/index.html',
326+
template: 'client/app.template.html',
327+
filename: '../client/app.html',
328328
alwaysWriteToDisk: true
329329
}
330330
config.plugins.push(

0 commit comments

Comments
 (0)