refactor(gen:test): runCmd returns a Promise instead of taking a callback

Author: Awk34

Diff for: src/test/main.test.js

@@ -108,20 +108,20 @@ describe('angular-fullstack:app', function() {
       return assertOnlyFiles(expectedFiles, path.normalize(dir)).should.eventually.be.fulfilled;
     });
 
-    it('passes JSCS', function(done) {
-      runCmd('grunt jscs', done);
+    it('passes JSCS', function() {
+      return runCmd('grunt jscs').should.be.fulfilled();
     });
 
-    it('passes JSHint', function(done) {
-      runCmd('grunt jshint', done);
+    it('passes JSHint', function() {
+      return runCmd('grunt jshint').should.be.fulfilled();
     });
 
-    it('passes client tests', function(done) {
-      runCmd('grunt test:client', done);
+    it('passes client tests', function() {
+      return runCmd('grunt test:client').should.be.fulfilled();
     });
 
-    it('passes server tests', function(done) {
-      runCmd('grunt test:server', done);
+    it('passes server tests', function() {
+      return runCmd('grunt test:server').should.be.fulfilled();
     });
 
     describe('with a generated endpont', function() {
@@ -135,8 +135,8 @@ describe('angular-fullstack:app', function() {
 
       it('should pass lint');
 
-      it('should run server tests successfully', function(done) {
-        runCmd('grunt test:server', done);
+      it('should run server tests successfully', function() {
+        return runCmd('grunt test:server').should.be.fulfilled();
       });
     });
 
@@ -151,8 +151,8 @@ describe('angular-fullstack:app', function() {
 
       it('should pass lint');
 
-      it('should run server tests successfully', function(done) {
-        runCmd('grunt test:server', done);
+      it('should run server tests successfully', function() {
+        return runCmd('grunt test:server').should.be.fulfilled();
       });
     });
 
@@ -167,8 +167,8 @@ describe('angular-fullstack:app', function() {
 
       it('should pass lint');
 
-      it('should run server tests successfully', function(done) {
-        runCmd('grunt test:server', done);
+      it('should run server tests successfully', function() {
+        return runCmd('grunt test:server').should.be.fulfilled();
       });
     });
 

Diff for: src/test/test-helpers.js

@@ -23,18 +23,19 @@ export function copyAsync(src, dest) {
 /**
  * Run the given command in a child process
  * @param {string} cmd - command to run
- * @param {doneCallback} done
+ * @returns {Promise}
  */
-export function runCmd(cmd, done) {
-  exec(cmd, {}, function(err, stdout, stderr) {
-    if(err) {
-      console.error(stdout);
-      throw new Error(`Error running command: ${cmd}`);
-      done(err);
-    } else {
-      if(DEBUG) console.log(stdout);
-      done();
-    }
+export function runCmd(cmd) {
+  return new Promise((resolve, reject) => {
+    exec(cmd, {}, function(err, stdout, stderr) {
+      if(err) {
+        console.error(stdout);
+        return reject(err);
+      } else {
+        if(DEBUG) console.log(`${cmd} stdout: ${stdout}`);
+        return resolve();
+      }
+    });
   });
 }