feat(client): add a bunch of types, use class in auth.service

Author: Awk34

Diff for: templates/app/client/app/account(auth)/login/login.controller.js

@@ -1,14 +1,40 @@
 'use strict';
+// @flow
+<%_ if(filters.flow) { -%>
+type User = {
+  name: string;
+  email: string;
+  password: string;
+};
+<%_ } -%>
+<%_ if(filters.ts) { -%>
+interface User {
+  name: string;
+  email: string;
+  password: string;
+}
+<%_ } -%>
 
 export default class LoginController {
+  user: User = {
+    name: '',
+    email: '',
+    password: ''
+  };
+  errors = {login: undefined};
+  submitted = false;
+  Auth;
+  <%_ if(filters.ngroute) { -%>
+  $location;
+  <%_ } if(filters.uirouter) { -%>
+  $state;<% } %>
+
   /*@ngInject*/
   constructor(Auth<% if (filters.ngroute) { %>, $location<% } %><% if (filters.uirouter) { %>, $state<% } %>) {
-    this.user = {};
-    this.errors = {};
-    this.submitted = false;
-
-    this.Auth = Auth;<% if (filters.ngroute) { %>
-    this.$location = $location;<% } if (filters.uirouter) { %>
+    this.Auth = Auth;
+    <%_ if(filters.ngroute) { -%>
+    this.$location = $location;
+    <%_ } if(filters.uirouter) { -%>
     this.$state = $state;<% } %>
   }
 

Diff for: templates/app/client/app/account(auth)/settings/settings.controller.js

@@ -1,8 +1,30 @@
 'use strict';
+// @flow
+<%_ if(filters.flow) { -%>
+type User = {
+  oldPassword: string;
+  newPassword: string;
+  confirmPassword: string;
+};
+<%_ } -%>
+<%_ if(filters.ts) { -%>
+interface User {
+  oldPassword: string;
+  newPassword: string;
+  confirmPassword: string;
+}
+<%_ } -%>
 
 export default class SettingsController {
-  errors = {};
+  user: User = {
+    oldPassword: '',
+    newPassword: '',
+    confirmPassword: ''
+  };
+  errors = {other: undefined};
+  message = '';
   submitted = false;
+  Auth;
 
   /*@ngInject*/
   constructor(Auth) {
@@ -12,7 +34,7 @@ export default class SettingsController {
   changePassword(form) {
     this.submitted = true;
 
-    if (form.$valid) {
+    if(form.$valid) {
       this.Auth.changePassword(this.user.oldPassword, this.user.newPassword)
         .then(() => {
           this.message = 'Password successfully changed.';

Diff for: templates/app/client/app/account(auth)/signup/signup.controller.js

@@ -1,44 +1,69 @@
 'use strict';
+// @flow
+<%_ if(filters.flow) { -%>
+type User = {
+  name: string;
+  email: string;
+  password: string;
+};
+<%_ } -%>
+<%_ if(filters.ts) { -%>
+interface User {
+  name: string;
+  email: string;
+  password: string;
+}
+<%_ } -%>
 
 export default class SignupController {
-  //start-non-standard
-  user = {};
+  user: User = {
+    name: '',
+    email: '',
+    password: ''
+  };
   errors = {};
   submitted = false;
-  //end-non-standard
+  Auth;
+  <%_ if(filters.ngroute) { -%>
+  $location;
+  <%_ } if(filters.uirouter) { -%>
+  $state;<% } %>
 
   /*@ngInject*/
   constructor(Auth<% if (filters.ngroute) { %>, $location<% } %><% if (filters.uirouter) { %>, $state<% } %>) {
-    this.Auth = Auth;<% if (filters.ngroute) { %>
-    this.$location = $location;<% } if (filters.uirouter) { %>
+    this.Auth = Auth;
+    <%_ if(filters.ngroute) { -%>
+    this.$location = $location;
+    <%_ } if(filters.uirouter) { -%>
     this.$state = $state;<% } %>
   }
 
   register(form) {
     this.submitted = true;
 
-    if (form.$valid) {
-      this.Auth.createUser({
+    if(form.$valid) {
+      return this.Auth.createUser({
         name: this.user.name,
         email: this.user.email,
         password: this.user.password
       })
       .then(() => {
         // Account created, redirect to home
-        <% if (filters.ngroute) { %>this.$location.path('/');<% } %><% if (filters.uirouter) { %>this.$state.go('main');<% } %>
+        <% if(filters.ngroute) { %>this.$location.path('/');<% } -%>
+        <% if(filters.uirouter) { %>this.$state.go('main');<% } -%>
       })
       .catch(err => {
         err = err.data;
         this.errors = {};
-<% if (filters.mongooseModels) { %>
+        <%_ if(filters.mongooseModels) { -%>
         // Update validity of form fields that match the mongoose errors
         angular.forEach(err.errors, (error, field) => {
           form[field].$setValidity('mongoose', false);
           this.errors[field] = error.message;
-        });<% }
-if (filters.sequelizeModels) { %>
+        });<% } %>
+        <%_ if(filters.sequelizeModels) { -%>
         // Update validity of form fields that match the sequelize errors
-        if (err.name) {
+        if(err.name) {
           angular.forEach(err.fields, field => {
             form[field].$setValidity('mongoose', false);
             this.errors[field] = err.message;

Diff for: templates/app/client/app/main/main.component.js

@@ -7,12 +7,18 @@ import uiRouter from 'angular-ui-router';<% } _%>
 import routing from './main.routes';
 
 export class MainController {
+  $http;
+  <%_ if(filters.socketio) { -%>
+  socket;<% } %>
+  awesomeThings = [];
+  <%_ if(filters.models) { -%>
+  newThing = '';<% } %>
+
   /*@ngInject*/
   constructor($http<% if(filters.socketio) { %>, $scope, socket<% } %>) {
-    this.$http = $http;<% if (filters.socketio) { %>
-    this.socket = socket;<% } %>
-    this.awesomeThings = [];
-    <%_ if (filters.socketio) { _%>
+    this.$http = $http;
+    <%_ if(filters.socketio) { -%>
+    this.socket = socket;
 
     $scope.$on('$destroy', function() {
       socket.unsyncUpdates('thing');

Diff for: templates/app/client/components/auth(auth)/auth.service.js

@@ -1,10 +1,17 @@
 'use strict';
 // @flow
+class User {
+  _id: string = '';
+  name: string = '';
+  email: string = '';
+  role: string = '';
+  $promise = undefined;
+}
 
 export function AuthService($location, $http, $cookies, $q, appConfig, Util, User) {
   'ngInject';
   var safeCb = Util.safeCb;
-  var currentUser = {};
+  var currentUser: User = new User();
   var userRoles = appConfig.userRoles || [];
 
   if ($cookies.get('token') && $location.path() !== '/logout') {
@@ -46,7 +53,7 @@ export function AuthService($location, $http, $cookies, $q, appConfig, Util, Use
      */
     logout() {
       $cookies.remove('token');
-      currentUser = {};
+      currentUser = new User();
     },
 
     /**

Diff for: templates/app/client/components/navbar/navbar.component.js

@@ -1,14 +1,19 @@
 'use strict';
 
 export class NavbarComponent {
-  //start-non-standard
   menu = [{
     'title': 'Home',
     <% if (filters.uirouter) { %>'state': 'main'<% } else { %>'link': '/'<% } %>
   }];
-  
+  <%_ if(!filters.uirouter) { -%>
+  $location;
+  <%_ } -%>
+  <%_ if (filters.auth) { -%>
+  isLoggedIn: Function;
+  isAdmin: Function;
+  getCurrentUser: Function;
+  <%_ } -%>
   isCollapsed = true;
-  //end-non-standard
   <%_ if(filters.ngroute || filters.auth) { _%>
 
   constructor(<% if(!filters.uirouter) { %>$location<% } if(!filters.uirouter && filters.auth) { %>, <% } if (filters.auth) { %>Auth<% } %>) {