Skip to content

Commit 036478d

Browse files
committed
update docs for heroku and openshift deployment
1 parent b14857b commit 036478d

File tree

3 files changed

+6
-22
lines changed

3 files changed

+6
-22
lines changed

heroku/index.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,6 @@ Generator.prototype.gitForcePush = function gitForcePush() {
161161
this.log(chalk.yellow('\nBecause you\'re using mongoose, you must add mongoDB to your heroku app.\n\t' + 'from `/dist`: ' + chalk.bold('heroku addons:add mongohq') + '\n'));
162162
hasWarning = true;
163163
}
164-
if(this.filters.socketio) {
165-
this.log(chalk.yellow('Because you\'re using socketIO, you must enable websockets on your heroku app.\n\t' + 'from `/dist`: ' + chalk.bold('heroku labs:enable websockets') + '\n'));
166-
hasWarning = true;
167-
}
168164

169165
if(this.filters.facebookAuth) {
170166
this.log(chalk.yellow('You will need to set environment variables for facebook auth. From `/dist`:\n\t' +
@@ -190,9 +186,8 @@ Generator.prototype.gitForcePush = function gitForcePush() {
190186
this.log(chalk.green('\nYou may need to address the issues mentioned above and restart the server for the app to work correctly.'));
191187
}
192188

193-
this.log(chalk.cyan('\nTo deploy a new build\n\t' + chalk.bold('grunt build') +
194-
'\nThen enter the dist folder to commit these updates:\n\t' + chalk.bold('cd dist && git add -A && git commit -m "describe your changes here"')));
195-
this.log(chalk.cyan('Finally, deploy your updated build to Heroku with\n\t' + chalk.bold('git push -f heroku master')));
189+
this.log(chalk.yellow('After app modification run\n\t' + chalk.bold('grunt build') +
190+
'\nThen deploy with\n\t' + chalk.bold('grunt buildcontrol:heroku')));
196191
}
197192
done();
198193
}.bind(this));

openshift/index.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ Generator.prototype.restartApp = function restartApp() {
267267
var hasWarning = false;
268268
var before_hostname = this.dist_repo_url.indexOf('@') + 1;
269269
var after_hostname = this.dist_repo_url.length - ( 'openshift'.length + 12 );
270-
host_url = 'http://' + this.dist_repo_url.slice(before_hostname, after_hostname);
270+
host_url = 'http://' + this.dist_repo_url.slice(before_hostname, after_hostname) + 'com';
271271

272272
if(this.filters.facebookAuth) {
273273
this.log(chalk.yellow('You will need to set environment variables for facebook auth:\n\t' +
@@ -294,7 +294,6 @@ Generator.prototype.restartApp = function restartApp() {
294294
'rhc app-restart -a ' + this.deployedName));
295295
}
296296
this.log(chalk.yellow('After app modification run\n\t' + chalk.bold('grunt build') +
297-
'\nThen enter the dist folder to commit these updates:\n\t' + chalk.bold('cd dist && git add -A && git commit -m "describe your changes here"')));
298-
this.log(chalk.green('Finally, deploy your updated build to OpenShift with\n\t' + chalk.bold('git push -f '+'openshift'+' master')));
297+
'\nThen deploy with\n\t' + chalk.bold('grunt buildcontrol:openshift')));
299298
}.bind(this));
300299
};

readme.md

+2-12
Original file line numberDiff line numberDiff line change
@@ -221,14 +221,6 @@ Deploying to OpenShift can be done in just a few steps:
221221

222222
A live application URL will be available in the output.
223223

224-
> **Enabling web sockets**
225-
>
226-
> If you're using socket.io, you will need to update the client to connect to the correct port for sockets to work.
227-
>
228-
> In `/client/components/socket/socket.service` update the socket to connect to port 8000. (with `my-openshift-app` being the deployed name of your app):
229-
>
230-
> var ioSocket = io.connect('my-openshift-app.com:8000');
231-
>
232224
> **oAuth**
233225
>
234226
> If you're using any oAuth strategies, you must set environment variables for your selected oAuth. For example, if we're using Facebook oAuth we would do this :
@@ -256,8 +248,7 @@ To make your deployment process easier consider using [grunt-build-control](http
256248

257249
Commit and push the resulting build, located in your dist folder:
258250

259-
cd dist && git add -A && git commit -m "describe your changes here"
260-
git push -f my-openshift-app master
251+
grunt buildcontrol:openshift
261252

262253
### Heroku
263254

@@ -297,8 +288,7 @@ To make your deployment process easier consider using [grunt-build-control](http
297288

298289
Commit and push the resulting build, located in your dist folder:
299290

300-
cd dist && git add -A && git commit -m "describe your changes here"
301-
git push -f heroku master
291+
grunt buildcontrol:heroku
302292

303293

304294
## Bower Components

0 commit comments

Comments
 (0)