Skip to content

Contribute TypeScript project detection to Smart Importer #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angelozerr opened this issue Apr 26, 2016 · 3 comments
Closed

Contribute TypeScript project detection to Smart Importer #54

angelozerr opened this issue Apr 26, 2016 · 3 comments

Comments

@angelozerr
Copy link
Owner

angelozerr commented Apr 26, 2016

Smart Importer is a very cool features to import project and discover while importing some files to add directly the well nature, etc

Today I have not TypeScript nature, but I think more and more we should have this TypeScript nature to hide for instance TypeScript from Project properties.

It should be cool when we import a project

  • it check that it exists a tsconfig.json or a ts files and add TypeScript nature to the project.
  • the buildpath is updated with directory folder which contains tsconfig.json

See sample with JPA at https://bugs.eclipse.org/bugs/show_bug.cgi?id=492323

@mickaelistria could you give me more information about "Smart Importer":

  • if I have understood, it will work only with Neon?
  • can I download none release of Neon to benefit with Smart Importer?
  • if each project uses RecursiveFileFinder to discover a file, is not a problem with performance? If we have JPA and TypeScript which provides smart importer, it means that files of project is visited twice?
@mickaelistria
Copy link
Contributor

I would recommend that as much as you can avoid a nature, do it. Natures introduce a lot of complexity both from maintenance and usage perspective.

About the Smart Importer, Neon M6 has it. However, the API is subject to change. Using the recursiveFileFinder can cause performance issue.

@angelozerr
Copy link
Owner Author

I would recommend that as much as you can avoid a nature, do it.

Many thanks for your recommandation! Today there are none nature. I use tsconfig.json to know if project is a typescript project or not. See my current work at #53 (comment)

@angelozerr
Copy link
Owner Author

@mickaelistria see https://github.com/angelozerr/typescript.java/wiki/TypeScript-BuildPath#typescript-nature if you are interested to know the rules how I manage "TypeScript Nature" without "Eclipse Nature".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants