@@ -388,13 +388,12 @@ protected ITypeScriptLint createTslint(File tslintFile, File tslintJsonFile, Fil
388
388
@ Override
389
389
public void compileWithTsserver (List <IFile > updatedTsFiles , List <IFile > removedTsFiles , IProgressMonitor monitor )
390
390
throws TypeScriptException {
391
- List <IFile > tsFilesToClosed = new ArrayList <>();
392
391
try {
393
392
List <String > tsFilesToCompile = new ArrayList <>();
394
393
// Collect ts files to compile by using tsserver to retrieve
395
394
// dependencies files.
396
395
// It works only if tsconfig.json declares "compileOnSave: true".
397
- if (collectTsFilesToCompile (updatedTsFiles , getClient (), tsFilesToCompile , tsFilesToClosed , false ,
396
+ if (collectTsFilesToCompile (updatedTsFiles , getClient (), tsFilesToCompile , false ,
398
397
monitor )) {
399
398
return ;
400
399
}
@@ -411,10 +410,6 @@ public void compileWithTsserver(List<IFile> updatedTsFiles, List<IFile> removedT
411
410
throw e ;
412
411
} catch (Exception e ) {
413
412
throw new TypeScriptException (e );
414
- } finally {
415
- for (IFile tsFile : tsFilesToClosed ) {
416
- closeFile (tsFile );
417
- }
418
413
}
419
414
}
420
415
@@ -429,22 +424,14 @@ public void compileWithTsserver(List<IFile> updatedTsFiles, List<IFile> removedT
429
424
* @throws Exception
430
425
*/
431
426
private boolean collectTsFilesToCompile (List <IFile > tsFiles , ITypeScriptServiceClient client ,
432
- List <String > tsFilesToCompile , List < IFile > tsFilesToClosed , boolean exclude , IProgressMonitor monitor )
427
+ List <String > tsFilesToCompile , boolean exclude , IProgressMonitor monitor )
433
428
throws Exception {
434
429
for (IFile tsFile : tsFiles ) {
435
430
if (monitor .isCanceled ()) {
436
431
return true ;
437
432
}
438
433
String filename = WorkbenchResourceUtil .getFileName (tsFile );
439
434
if (!tsFilesToCompile .contains (filename )) {
440
- // tsserver needs that file must be opened, force the "open"
441
- // if file is not opened.
442
- // see
443
- // https://github.com/angelozerr/typescript.java/issues/142
444
- if (getOpenedFile (tsFile ) == null ) {
445
- openFile (tsFile , null );
446
- tsFilesToClosed .add (tsFile );
447
- }
448
435
collectTsFilesToCompile (filename , client , tsFilesToCompile , exclude );
449
436
}
450
437
}
0 commit comments