Remove duplicate solution of JoinIntervals task

Author: andrei-punko

src/main/java/by/andd3dfx/common/JoinIntervals.java

@@ -16,15 +16,12 @@
  */
 public class JoinIntervals {
 
-    /**
-     * Home version
-     */
     public static String transform(int[] a) {
-        List<String> items = new ArrayList<>();
         if (a.length == 0) {
             return "";
         }
 
+        List<String> items = new ArrayList<>();
         int lastItem = a[0];
         int startIntervalValue = a[0];
         boolean intervalDetected = false;
@@ -55,41 +52,7 @@ public static String transform(int[] a) {
             items.add(String.valueOf(lastItem));
         }
 
-        return items.stream().collect(Collectors.joining(","));
-    }
-
-    /**
-     * Interview version
-     */
-    public static String transform2(int[] nums) {
-        var result = new ArrayList<String>();
-        var len = nums.length;
-        int leftBorderIndex = 0;
-        boolean intervalDetected = false;
-
-        int i = 0;
-        for (; i < len - 1; i++) {
-            if (nums[i + 1] - nums[i] == 1) {
-                if (!intervalDetected) {
-                    leftBorderIndex = i;
-                    intervalDetected = true;
-                }
-            } else {
-                if (intervalDetected) {
-                    result.add(nums[leftBorderIndex] + "-" + nums[i]);
-                    intervalDetected = false;
-                } else {
-                    result.add(String.valueOf(nums[i]));
-                }
-            }
-        }
-
-        if (intervalDetected) {
-            result.add(nums[leftBorderIndex] + "-" + nums[i]);
-        } else {
-            result.add(String.valueOf(nums[i]));
-        }
-
-        return result.stream().collect(Collectors.joining(","));
+        return items.stream()
+                .collect(Collectors.joining(","));
     }
 }

src/test/java/by/andd3dfx/common/JoinIntervalsTest.java

@@ -2,58 +2,32 @@
 
 import org.junit.Test;
 
+import static by.andd3dfx.common.JoinIntervals.transform;
 import static org.assertj.core.api.Assertions.assertThat;
 
 public class JoinIntervalsTest {
 
     @Test
-    public void transform() {
-        assertThat(JoinIntervals.transform(new int[]{}))
+    public void testTransform() {
+        assertThat(transform(new int[]{}))
                 .isEqualTo("");
 
-        assertThat(JoinIntervals.transform(new int[]{1}))
+        assertThat(transform(new int[]{1}))
                 .isEqualTo("1");
 
-        assertThat(JoinIntervals.transform(new int[]{1, 2}))
+        assertThat(transform(new int[]{1, 2}))
                 .isEqualTo("1-2");
 
-        assertThat(JoinIntervals.transform(new int[]{1, 3}))
+        assertThat(transform(new int[]{1, 3}))
                 .isEqualTo("1,3");
 
-        assertThat(JoinIntervals.transform(new int[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}))
+        assertThat(transform(new int[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}))
                 .isEqualTo("1-10");
 
-        assertThat(JoinIntervals.transform(new int[]{2, 3, 5, 6, 7, 8, 11, 20, 21, 22}))
+        assertThat(transform(new int[]{2, 3, 5, 6, 7, 8, 11, 20, 21, 22}))
                 .isEqualTo("2-3,5-8,11,20-22");
 
-        assertThat(JoinIntervals.transform(new int[]{1, 3, 5, 7, 9, 11, 20, 22}))
-                .isEqualTo("1,3,5,7,9,11,20,22");
-    }
-
-    @Test
-    public void transform2() {
-        /*
-         * Not covered this case on interview
-        assertThat(NumberIntervals.transform2(new int[]{}))
-                .isEqualTo("");
-         */
-
-        assertThat(JoinIntervals.transform2(new int[]{1}))
-                .isEqualTo("1");
-
-        assertThat(JoinIntervals.transform2(new int[]{1, 2}))
-                .isEqualTo("1-2");
-
-        assertThat(JoinIntervals.transform2(new int[]{1, 3}))
-                .isEqualTo("1,3");
-
-        assertThat(JoinIntervals.transform2(new int[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}))
-                .isEqualTo("1-10");
-
-        assertThat(JoinIntervals.transform2(new int[]{2, 3, 5, 6, 7, 8, 11, 20, 21, 22}))
-                .isEqualTo("2-3,5-8,11,20-22");
-
-        assertThat(JoinIntervals.transform2(new int[]{1, 3, 5, 7, 9, 11, 20, 22}))
+        assertThat(transform(new int[]{1, 3, 5, 7, 9, 11, 20, 22}))
                 .isEqualTo("1,3,5,7,9,11,20,22");
     }
 }