Skip to content

Commit ceb9171

Browse files
committed
reasons for xfails
1 parent e2cfa77 commit ceb9171

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

pandas/tests/formats/test_css.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_css_parse_normalisation(name, norm, abnorm):
2828
assert_same_resolution(norm, abnorm)
2929

3030

31-
@pytest.mark.xfail
31+
@pytest.mark.xfail(reason='CSS comments not yet stripped')
3232
def test_css_parse_comments():
3333
assert_same_resolution('hello: world',
3434
'hello/* foo */:/* bar \n */ world /*;not:here*/')
@@ -41,7 +41,8 @@ def test_css_parse_specificity():
4141
pass # TODO
4242

4343

44-
@pytest.mark.xfail
44+
@pytest.mark.xfail(reason='Splitting CSS declarations not yet sensitive to '
45+
'; in CSS strings')
4546
def test_css_parse_strings():
4647
# semicolons in strings
4748
assert_resolves('background-image: url(\'http://blah.com/foo?a;b=c\')',
@@ -91,7 +92,7 @@ def test_css_side_shorthands(shorthand, expansions):
9192
{})
9293

9394

94-
@pytest.mark.xfail
95+
@pytest.mark.xfail(reason='CSS font shorthand not yet handled')
9596
@pytest.mark.parametrize('css,props', [
9697
('font: italic bold 12pt helvetica,sans-serif',
9798
{'font-family': 'helvetica,sans-serif',
@@ -108,7 +109,7 @@ def test_css_font_shorthand(css, props):
108109
assert_resolves(css, props)
109110

110111

111-
@pytest.mark.xfail
112+
@pytest.mark.xfail(reason='CSS background shorthand not yet handled')
112113
@pytest.mark.parametrize('css,props', [
113114
('background: blue', {'background-color': 'blue'}),
114115
('background: fixed blue',
@@ -118,7 +119,7 @@ def test_css_background_shorthand(css, props):
118119
assert_resolves(css, props)
119120

120121

121-
@pytest.mark.xfail
122+
@pytest.mark.xfail(reason='CSS border shorthand not yet handled')
122123
@pytest.mark.parametrize('style,equiv', [
123124
('border: 1px solid red',
124125
'border-width: 1px; border-style: solid; border-color: red'),

pandas/tests/formats/test_to_excel.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,14 @@
7373
('text-shadow: 0px -0em 2px #CCC', {'font': {'shadow': True}}),
7474
('text-shadow: 0px -0em 2px', {'font': {'shadow': True}}),
7575
('text-shadow: 0px -2em', {'font': {'shadow': True}}),
76-
# text-shadow with color first not yet implemented
7776
pytest.mark.xfail(('text-shadow: #CCC 3px 3px 3px',
78-
{'font': {'shadow': True}})),
77+
{'font': {'shadow': True}}),
78+
reason='text-shadow with color preceding width not yet '
79+
'identified as shadow'),
7980
pytest.mark.xfail(('text-shadow: #999 0px 0px 0px',
80-
{'font': {'shadow': False}})),
81+
{'font': {'shadow': False}}),
82+
reason='text-shadow with color preceding zero width not '
83+
'yet identified as non-shadow'),
8184
# FILL
8285
# - color, fillType
8386
('background-color: red', {'fill': {'fgColor': 'FF0000',
@@ -209,6 +212,7 @@ def test_css_to_excel_inherited(css, inherited, expected):
209212
assert expected == convert(css)
210213

211214

212-
@pytest.mark.xfail
215+
@pytest.mark.xfail(reason='We are not currently warning for all unconverted '
216+
'CSS, but possibly should')
213217
def test_css_to_excel_warns_when_not_supported():
214218
pass # TODO

0 commit comments

Comments
 (0)