Skip to content

Commit 9a62699

Browse files
committed
Fix tests and add TODOs to tests
1 parent 7c54a69 commit 9a62699

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

pandas/tests/formats/test_css.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_css_parse_comments():
3838
markers like !important, but we should
3939
ignore them in the future''')
4040
def test_css_parse_specificity():
41-
pass
41+
pass # TODO
4242

4343

4444
@pytest.mark.xfail

pandas/tests/formats/test_to_excel.py

+10-6
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@
8484
'patternType': 'solid'}}),
8585
# BORDER
8686
# - style
87-
# TODO: need to check this produces valid OpenXML without color
8887
('border-style: solid',
8988
{'border': {'top': {'style': 'medium'},
9089
'bottom': {'style': 'medium'},
@@ -96,11 +95,16 @@
9695
{'border': {'top': {'style': 'mediumDashDotDot'}}}),
9796
('border-top-style: dashed',
9897
{'border': {'top': {'style': 'mediumDashed'}}}),
98+
# TODO: test other widths
9999
# - color
100+
# TODO
100101
# ALIGNMENT
101102
# - horizontal
103+
# TODO
102104
# - vertical
105+
# TODO
103106
# - wrap_text
107+
# TODO
104108
])
105109
def test_css_to_excel(css, expected):
106110
convert = CSSToExcelConverter()
@@ -117,10 +121,10 @@ def test_css_to_excel_multiple():
117121
unused: something;
118122
''')
119123
assert {"font": {"bold": True},
120-
"border": {"top": {"style": "hair"},
121-
"right": {"style": "hair"},
122-
"bottom": {"style": "hair"},
123-
"left": {"style": "hair"}},
124+
"border": {"top": {"style": "thin"},
125+
"right": {"style": "thin"},
126+
"bottom": {"style": "thin"},
127+
"left": {"style": "thin"}},
124128
"alignment": {"horizontal": "center",
125129
"vertical": "top"}} == actual
126130

@@ -145,4 +149,4 @@ def test_css_to_excel_inherited(css, inherited, expected):
145149

146150
@pytest.mark.xfail
147151
def test_css_to_excel_warns_when_not_supported():
148-
pass
152+
pass # TODO

0 commit comments

Comments
 (0)