Merge pull request #66 from algolia/cursorchanged-fired-on-hover

Ensure the cursorchanged event is also triggered on mouseover

Author: redox

dist/autocomplete.angular.js

@@ -1505,7 +1505,7 @@
 
 	  _onSuggestionMouseEnter: function onSuggestionMouseEnter($e) {
 	    this._removeCursor();
-	    this._setCursor(DOM.element($e.currentTarget), true);
+	    this._setCursor(DOM.element($e.currentTarget));
 	  },
 
 	  _onSuggestionMouseLeave: function onSuggestionMouseLeave() {
@@ -1548,12 +1548,10 @@
 	    return this.$menu.find('.aa-cursor').first();
 	  },
 
-	  _setCursor: function setCursor($el, silent) {
+	  _setCursor: function setCursor($el) {
 	    $el.first().addClass('aa-cursor');
-
-	    if (!silent) {
-	      this.trigger('cursorMoved');
-	    }
+	    console.log('cursorMoved');
+	    this.trigger('cursorMoved');
 	  },
 
 	  _removeCursor: function removeCursor() {

dist/autocomplete.angular.min.js

@@ -1555,7 +1555,7 @@
 
 	  _onSuggestionMouseEnter: function onSuggestionMouseEnter($e) {
 	    this._removeCursor();
-	    this._setCursor(DOM.element($e.currentTarget), true);
+	    this._setCursor(DOM.element($e.currentTarget));
 	  },
 
 	  _onSuggestionMouseLeave: function onSuggestionMouseLeave() {
@@ -1598,12 +1598,10 @@
 	    return this.$menu.find('.aa-cursor').first();
 	  },
 
-	  _setCursor: function setCursor($el, silent) {
+	  _setCursor: function setCursor($el) {
 	    $el.first().addClass('aa-cursor');
-
-	    if (!silent) {
-	      this.trigger('cursorMoved');
-	    }
+	    console.log('cursorMoved');
+	    this.trigger('cursorMoved');
 	  },
 
 	  _removeCursor: function removeCursor() {

dist/autocomplete.jquery.js

@@ -2782,7 +2782,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	  _onSuggestionMouseEnter: function onSuggestionMouseEnter($e) {
 	    this._removeCursor();
-	    this._setCursor(DOM.element($e.currentTarget), true);
+	    this._setCursor(DOM.element($e.currentTarget));
 	  },
 
 	  _onSuggestionMouseLeave: function onSuggestionMouseLeave() {
@@ -2825,12 +2825,10 @@ return /******/ (function(modules) { // webpackBootstrap
 	    return this.$menu.find('.aa-cursor').first();
 	  },
 
-	  _setCursor: function setCursor($el, silent) {
+	  _setCursor: function setCursor($el) {
 	    $el.first().addClass('aa-cursor');
-
-	    if (!silent) {
-	      this.trigger('cursorMoved');
-	    }
+	    console.log('cursorMoved');
+	    this.trigger('cursorMoved');
 	  },
 
 	  _removeCursor: function removeCursor() {

dist/autocomplete.jquery.min.js

@@ -74,7 +74,7 @@ _.mixin(Dropdown.prototype, EventEmitter, {
 
   _onSuggestionMouseEnter: function onSuggestionMouseEnter($e) {
     this._removeCursor();
-    this._setCursor(DOM.element($e.currentTarget), true);
+    this._setCursor(DOM.element($e.currentTarget));
   },
 
   _onSuggestionMouseLeave: function onSuggestionMouseLeave() {
@@ -117,12 +117,9 @@ _.mixin(Dropdown.prototype, EventEmitter, {
     return this.$menu.find(_.className(this.cssClasses.prefix, this.cssClasses.cursor)).first();
   },
 
-  _setCursor: function setCursor($el, silent) {
+  _setCursor: function setCursor($el) {
     $el.first().addClass(_.className(this.cssClasses.prefix, this.cssClasses.cursor, true));
-
-    if (!silent) {
-      this.trigger('cursorMoved');
-    }
+    this.trigger('cursorMoved');
   },
 
   _removeCursor: function removeCursor() {

dist/autocomplete.js

@@ -99,7 +99,7 @@ describe('Dropdown', function() {
       expect($suggestion).toHaveClass('aa-cursor');
     });
 
-    it('should not trigger cursorMoved', function() {
+    it('should trigger cursorMoved', function() {
       var spy;
       var $suggestion;
 
@@ -108,7 +108,7 @@ describe('Dropdown', function() {
       $suggestion = this.$menu.find('.aa-suggestion').first();
       $suggestion.mouseenter();
 
-      expect(spy).not.toHaveBeenCalled();
+      expect(spy).toHaveBeenCalled();
     });
   });