Skip to content

Commit 5f1ec80

Browse files
authored
Merge pull request jsx-eslint#1621 from kamataryo/master
Add null avoidance in rule `require-optimization`
2 parents f40b7b8 + 22c9237 commit 5f1ec80

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/rules/require-optimization.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ module.exports = {
106106
let hasPR = false;
107107
if (node.value && node.value.elements) {
108108
for (let i = 0, l = node.value.elements.length; i < l; i++) {
109-
if (node.value.elements[i].name === 'PureRenderMixin') {
109+
if (node.value.elements[i] && node.value.elements[i].name === 'PureRenderMixin') {
110110
hasPR = true;
111111
break;
112112
}

tests/lib/rules/require-optimization.js

+4
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ ruleTester.run('react-require-optimization', rule, {
112112
`,
113113
parser: 'babel-eslint',
114114
options: [{allowDecorators: ['renderPure', 'pureRender']}]
115+
}, {
116+
code: `
117+
const obj = { prop: [,,,,,] }
118+
`
115119
}],
116120

117121
invalid: [{

0 commit comments

Comments
 (0)