Skip to content

Commit a3d5864

Browse files
committed
build: disable UT testing multiple node versions
With this change we disable running UTs on multiple node.js versions. This is mainly an intermin solution until we find the root cause of the memory increase and OOM errors during bazel test.
1 parent c0d1bec commit a3d5864

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

tools/toolchain_info.bzl

+11-9
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,23 @@
33
# the name can be anything the user wants this is just added to the target to create unique names
44
# the order will match against the order in the TOOLCHAIN_VERSION list.
55
TOOLCHAINS_NAMES = [
6-
"node14",
6+
# TODO enable one we know more why there is a memory usage increase
7+
# "node14",
78
"node16",
89
]
910

1011
# this is the list of toolchains that should be used and are registered with nodejs_register_toolchains in the WORKSPACE file
1112
TOOLCHAINS_VERSIONS = [
13+
# TODO enable one we know more why there is a memory usage increase
14+
# select({
15+
# "@bazel_tools//src/conditions:linux_x86_64": "@node14_linux_amd64//:node_toolchain",
16+
# "@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
17+
# "@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
18+
# }),
1219
select({
13-
"@bazel_tools//src/conditions:linux_x86_64": "@node14_linux_amd64//:node_toolchain",
14-
"@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
15-
"@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
16-
}),
17-
select({
18-
"@bazel_tools//src/conditions:linux_x86_64": "@node14_linux_amd64//:node_toolchain",
19-
"@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
20-
"@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
20+
"@bazel_tools//src/conditions:linux_x86_64": "@node16_linux_amd64//:node_toolchain",
21+
"@bazel_tools//src/conditions:darwin": "@node16_darwin_amd64//:node_toolchain",
22+
"@bazel_tools//src/conditions:windows": "@node16_windows_amd64//:node_toolchain",
2123
}),
2224
]
2325

0 commit comments

Comments
 (0)