Skip to content

Commit 810d221

Browse files
committed
refactor(@angular-devkit/build-webpack): align builders source directory structure with build-angular
The source code for the builders within the `@angular-devkit/build-webpack` package have been moved into a `builders` subdirectory to more closely align with the structure of the builders in the `@angular-devkit/build-angular` package. An initial `package.json` exports field definition has also been added that currently continues to allow deep imports.
1 parent 8e9b675 commit 810d221

File tree

10 files changed

+30
-21
lines changed

10 files changed

+30
-21
lines changed

packages/angular_devkit/build_webpack/BUILD.bazel

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ package(default_visibility = ["//visibility:public"])
1414

1515
ts_json_schema(
1616
name = "webpack_schema",
17-
src = "src/webpack/schema.json",
17+
src = "src/builders/webpack/schema.json",
1818
)
1919

2020
ts_json_schema(
2121
name = "webpack_dev_server_schema",
22-
src = "src/webpack-dev-server/schema.json",
22+
src = "src/builders/webpack-dev-server/schema.json",
2323
)
2424

2525
ts_library(
@@ -32,14 +32,14 @@ ts_library(
3232
"src/**/*_spec.ts",
3333
],
3434
) + [
35-
"//packages/angular_devkit/build_webpack:src/webpack-dev-server/schema.ts",
36-
"//packages/angular_devkit/build_webpack:src/webpack/schema.ts",
35+
"//packages/angular_devkit/build_webpack:src/builders/webpack-dev-server/schema.ts",
36+
"//packages/angular_devkit/build_webpack:src/builders/webpack/schema.ts",
3737
],
3838
data = [
3939
"builders.json",
4040
"package.json",
41-
"src/webpack-dev-server/schema.json",
42-
"src/webpack/schema.json",
41+
"src/builders/webpack-dev-server/schema.json",
42+
"src/builders/webpack/schema.json",
4343
],
4444
module_name = "@angular-devkit/build-webpack",
4545
module_root = "src/index.d.ts",

packages/angular_devkit/build_webpack/builders.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@
22
"$schema": "../architect/src/builders-schema.json",
33
"builders": {
44
"build": {
5-
"implementation": "./src/webpack",
6-
"schema": "./src/webpack/schema.json",
5+
"implementation": "./src/builders/webpack",
6+
"schema": "./src/builders/webpack/schema.json",
77
"description": "Build a webpack app."
88
},
99
"webpack": {
10-
"implementation": "./src/webpack",
11-
"schema": "./src/webpack/schema.json",
10+
"implementation": "./src/builders/webpack",
11+
"schema": "./src/builders/webpack/schema.json",
1212
"description": "Build a webpack app."
1313
},
1414
"dev-server": {
15-
"implementation": "./src/webpack-dev-server",
16-
"schema": "./src/webpack-dev-server/schema.json",
15+
"implementation": "./src/builders/webpack-dev-server",
16+
"schema": "./src/builders/webpack-dev-server/schema.json",
1717
"description": "Serve a webpack app."
1818
},
1919
"webpack-dev-server": {
20-
"implementation": "./src/webpack-dev-server",
21-
"schema": "./src/webpack-dev-server/schema.json",
20+
"implementation": "./src/builders/webpack-dev-server",
21+
"schema": "./src/builders/webpack-dev-server/schema.json",
2222
"description": "Serve a webpack app."
2323
}
2424
}

packages/angular_devkit/build_webpack/package.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@
66
"main": "src/index.js",
77
"typings": "src/index.d.ts",
88
"builders": "builders.json",
9+
"exports": {
10+
".": {
11+
"types": "./src/index.d.ts",
12+
"default": "./src/index.js"
13+
},
14+
"./package.json": "./package.json",
15+
"./*": "./*.js",
16+
"./*.js": "./*.js"
17+
},
918
"dependencies": {
1019
"@angular-devkit/architect": "0.0.0-EXPERIMENTAL-PLACEHOLDER",
1120
"rxjs": "7.8.1"

packages/angular_devkit/build_webpack/src/webpack-dev-server/index.ts renamed to packages/angular_devkit/build_webpack/src/builders/webpack-dev-server/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { resolve as pathResolve } from 'path';
1111
import { Observable, from, isObservable, of, switchMap } from 'rxjs';
1212
import webpack from 'webpack';
1313
import WebpackDevServer from 'webpack-dev-server';
14-
import { getEmittedFiles, getWebpackConfig } from '../utils';
14+
import { getEmittedFiles, getWebpackConfig } from '../../utils';
1515
import { BuildResult, WebpackFactory, WebpackLoggingCallback } from '../webpack';
1616
import { Schema as WebpackDevServerBuilderSchema } from './schema';
1717

packages/angular_devkit/build_webpack/src/webpack-dev-server/index_spec.ts renamed to packages/angular_devkit/build_webpack/src/builders/webpack-dev-server/index_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ describe('Dev Server Builder', () => {
4141
}
4242

4343
beforeEach(async () => {
44-
const ngJsonPath = path.join(__dirname, '../../test/basic-app/angular.json');
44+
const ngJsonPath = path.join(__dirname, '../../../test/basic-app/angular.json');
4545
const workspaceRoot = path.dirname(require.resolve(ngJsonPath));
4646
await createArchitect(workspaceRoot);
4747
});

packages/angular_devkit/build_webpack/src/webpack/index.ts renamed to packages/angular_devkit/build_webpack/src/builders/webpack/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { BuilderContext, BuilderOutput, createBuilder } from '@angular-devkit/ar
1010
import { resolve as pathResolve } from 'path';
1111
import { Observable, from, isObservable, of, switchMap } from 'rxjs';
1212
import webpack from 'webpack';
13-
import { EmittedFiles, getEmittedFiles, getWebpackConfig } from '../utils';
13+
import { EmittedFiles, getEmittedFiles, getWebpackConfig } from '../../utils';
1414
import { Schema as RealWebpackBuilderSchema } from './schema';
1515

1616
export type WebpackBuilderSchema = RealWebpackBuilderSchema;

packages/angular_devkit/build_webpack/src/webpack/index_spec.ts renamed to packages/angular_devkit/build_webpack/src/builders/webpack/index_spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('Webpack Builder basic test', () => {
3939
}
4040

4141
describe('basic app', () => {
42-
const ngJsonPath = path.join(__dirname, '../../test/basic-app/angular.json');
42+
const ngJsonPath = path.join(__dirname, '../../../test/basic-app/angular.json');
4343
const workspaceRoot = path.dirname(require.resolve(ngJsonPath));
4444
const outputPath = join(normalize(workspaceRoot), 'dist');
4545

@@ -90,7 +90,7 @@ describe('Webpack Builder basic test', () => {
9090

9191
describe('Angular app', () => {
9292
jasmine.DEFAULT_TIMEOUT_INTERVAL = 150000;
93-
const ngJsonPath = path.join(__dirname, '../../test/angular-app/angular.json');
93+
const ngJsonPath = path.join(__dirname, '../../../test/angular-app/angular.json');
9494
const workspaceRoot = path.dirname(require.resolve(ngJsonPath));
9595
const outputPath = join(normalize(workspaceRoot), 'dist');
9696

packages/angular_devkit/build_webpack/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
export * from './webpack';
10-
export * from './webpack-dev-server';
9+
export * from './builders/webpack';
10+
export * from './builders/webpack-dev-server';
1111
export { EmittedFiles } from './utils';

0 commit comments

Comments
 (0)