Skip to content

Commit 0716932

Browse files
committed
remove linters as golangci-lint doesnt support go1.23rc builds
golangci/golangci-lint#4837 Signed-off-by: Akhil Mohan <[email protected]>
1 parent 0f8526f commit 0716932

File tree

1 file changed

+31
-31
lines changed

1 file changed

+31
-31
lines changed

.github/workflows/ci.yml

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,29 @@ jobs:
1313
#
1414
# golangci-lint
1515
#
16-
linters:
17-
permissions:
18-
contents: read # for actions/checkout to fetch code
19-
pull-requests: read # for golangci/golangci-lint-action to fetch pull requests
20-
name: Linters
21-
runs-on: ${{ matrix.os }}
22-
timeout-minutes: 10
23-
24-
strategy:
25-
matrix:
26-
os: [ubuntu-24.04, actuated-arm64-4cpu-16gb, macos-12, windows-2019]
27-
exclude:
28-
- os: ${{ github.repository != 'containerd/containerd' && 'actuated-arm64-4cpu-16gb' }}
29-
30-
31-
steps:
32-
- uses: actions/checkout@v4
33-
- uses: ./.github/actions/install-go
34-
- uses: golangci/golangci-lint-action@v6
35-
with:
36-
version: v1.59.1
37-
skip-cache: true
38-
args: --timeout=8m
16+
# linters:
17+
# permissions:
18+
# contents: read # for actions/checkout to fetch code
19+
# pull-requests: read # for golangci/golangci-lint-action to fetch pull requests
20+
# name: Linters
21+
# runs-on: ${{ matrix.os }}
22+
# timeout-minutes: 10
23+
#
24+
# strategy:
25+
# matrix:
26+
# os: [ubuntu-24.04, actuated-arm64-4cpu-16gb, macos-12, windows-2019]
27+
# exclude:
28+
# - os: ${{ github.repository != 'containerd/containerd' && 'actuated-arm64-4cpu-16gb' }}
29+
#
30+
#
31+
# steps:
32+
# - uses: actions/checkout@v4
33+
# - uses: ./.github/actions/install-go
34+
# - uses: golangci/golangci-lint-action@v6
35+
# with:
36+
# version: v1.59.1
37+
# skip-cache: true
38+
# args: --timeout=8m
3939

4040
#
4141
# Project checks
@@ -117,7 +117,7 @@ jobs:
117117
# Well-known architectures are covered in release.yml.
118118
crossbuild:
119119
name: Crossbuild Binaries
120-
needs: [project, linters, protos, man]
120+
needs: [project, protos, man]
121121
runs-on: ubuntu-24.04
122122
timeout-minutes: 10
123123
strategy:
@@ -186,7 +186,7 @@ jobs:
186186
name: Binaries
187187
runs-on: ${{ matrix.os }}
188188
timeout-minutes: 20
189-
needs: [project, linters, protos, man]
189+
needs: [project, protos, man]
190190

191191
strategy:
192192
matrix:
@@ -211,7 +211,7 @@ jobs:
211211
name: Windows Integration
212212
runs-on: ${{ matrix.os }}
213213
timeout-minutes: 90
214-
needs: [project, linters, protos, man]
214+
needs: [project, protos, man]
215215
env:
216216
GOTEST: gotestsum --
217217

@@ -377,7 +377,7 @@ jobs:
377377
name: Linux Integration
378378
runs-on: ${{ matrix.os }}
379379
timeout-minutes: 40
380-
needs: [project, linters, protos, man]
380+
needs: [project, protos, man]
381381

382382
strategy:
383383
fail-fast: false
@@ -521,7 +521,7 @@ jobs:
521521
name: Vagrant integration
522522
runs-on: ubuntu-24.04
523523
timeout-minutes: 60
524-
needs: [project, linters, protos, man]
524+
needs: [project, protos, man]
525525

526526
strategy:
527527
fail-fast: false
@@ -595,7 +595,7 @@ jobs:
595595

596596
runs-on: ubuntu-24.04
597597
timeout-minutes: 40
598-
needs: [project, linters, protos, man]
598+
needs: [project, protos, man]
599599

600600
steps:
601601
- uses: actions/checkout@v4
@@ -618,7 +618,7 @@ jobs:
618618
name: MacOS unit tests
619619
runs-on: macos-12
620620
timeout-minutes: 10
621-
needs: [project, linters, protos, man]
621+
needs: [project, protos, man]
622622
env:
623623
GOTEST: gotestsum --
624624

@@ -655,7 +655,7 @@ jobs:
655655
name: Report required job statuses
656656
runs-on: ubuntu-latest
657657
# List job dependencies which are required to pass status checks in order to be merged via merge queue.
658-
needs: [linters, project, protos, binaries, integration-linux, integration-windows, tests-cri-in-userns, tests-mac-os]
658+
needs: [project, protos, binaries, integration-linux, integration-windows, tests-cri-in-userns, tests-mac-os]
659659
if: ${{ always() }}
660660
steps:
661661
- run: exit 1

0 commit comments

Comments
 (0)