handle 204 no-content, fixes #27

Author: ajaishankar

src/fetcher.ts

@@ -136,6 +136,9 @@ function getFetchParams(request: Request) {
 
 async function getResponseData(response: Response) {
   const contentType = response.headers.get('content-type')
+  if (response.status === 204 /* no content */) {
+    return undefined
+  }
   if (contentType && contentType.indexOf('application/json') !== -1) {
     return await response.json()
   }

test/fetch.test.ts

@@ -111,6 +111,13 @@ describe('fetch', () => {
     expect(data.headers).not.toHaveProperty('content-type')
   })
 
+  it(`POST /nocontent`, async () => {
+    const fun = fetcher.path('/nocontent').method('post').create()
+    const { status, data } = await fun(undefined)
+    expect(status).toBe(204)
+    expect(data).toBeUndefined()
+  })
+
   it('GET /error', async () => {
     expect.assertions(3)
 

test/mocks/handlers.ts

@@ -64,6 +64,9 @@ const methods = {
           )
         : res(ctx.status(status))
     }),
+    rest.post(`${HOST}/nocontent`, (req, res, ctx) => {
+      return res(ctx.status(204))
+    }),
     rest.get(`${HOST}/defaulterror`, (req, res, ctx) => {
       return res(ctx.status(500), ctx.body('internal server error'))
     }),

test/paths.ts

@@ -61,6 +61,14 @@ export type paths = {
     patch: BodyAndQuery
     delete: BodyAndQuery
   }
+  '/nocontent': {
+    post: {
+      parameters: {}
+      responses: {
+        204: unknown
+      }
+    }
+  }
   '/error/{status}': {
     get: {
       parameters: {