Skip to content

Commit 7dda84a

Browse files
committed
[eslint config] [deps] [minor] update jsx-a11y plugin; enable label-has-associated-control rule
This is semver-minor, because the `label-has-associated-control` rule is the same as the `label-has-for` rule, theoretically. Both remain enabled, but `label-has-for` will be disabled in the future if this rule proves out.
1 parent 5d1f4b9 commit 7dda84a

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

packages/eslint-config-airbnb/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"eslint": "^4.19.1",
6565
"eslint-find-rules": "^3.3.1",
6666
"eslint-plugin-import": "^2.13.0",
67-
"eslint-plugin-jsx-a11y": "^6.0.3",
67+
"eslint-plugin-jsx-a11y": "^6.1.0",
6868
"eslint-plugin-react": "^7.10.0",
6969
"in-publish": "^2.0.0",
7070
"react": ">= 0.13.0",
@@ -74,7 +74,7 @@
7474
"peerDependencies": {
7575
"eslint": "^4.19.1",
7676
"eslint-plugin-import": "^2.13.0",
77-
"eslint-plugin-jsx-a11y": "^6.0.3",
77+
"eslint-plugin-jsx-a11y": "^6.1.0",
7878
"eslint-plugin-react": "^7.10.0"
7979
},
8080
"engines": {

packages/eslint-config-airbnb/rules/react-a11y.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,16 @@ module.exports = {
5656
allowChildren: false,
5757
}],
5858

59+
// Enforce that a label tag has a text label and an associated control.
60+
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/docs/rules/label-has-associated-control.md
61+
'jsx-a11y/label-has-associated-control': ['error', {
62+
labelComponents: [],
63+
labelAttributes: [],
64+
controlComponents: [],
65+
assert: 'both',
66+
depth: 25
67+
}],
68+
5969
// require that mouseover/out come with focus/blur, for keyboard-only users
6070
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md
6171
'jsx-a11y/mouse-events-have-key-events': 'error',

0 commit comments

Comments
 (0)