Skip to content

Commit be35f03

Browse files
e-schultzsmithad15
authored andcommitted
fix(build): No chai for you (#209)
The chai type def has this... ``` interface Object { should: Chai.Assertion; } ``` When we run build, on files that have things like: `let x = (y:Object):Obect => { }` In the resulting file.d.ts ``` /// <reference types="chai" /> ``` Gets added, causing things to blow up for people. Not good. Temp fix for now - when running build, uninstall the types - then re-install them after. Not happy with this, but rather this than having a patch causing breaking builds for using 3.3.8.
1 parent 6421bea commit be35f03

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

packages/store/CHANGELOG.md

+12
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
# 3.3.9
2+
3+
### Fixes
4+
5+
* Temp update to npm build to uninstall typings for chai/sinon-chai so `/// <reference types="chai" />` doesn't get added to files.
6+
7+
# 3.3.8
8+
9+
### Fixes
10+
11+
* Manual fix of build to remove chai type reference
12+
113
# 3.3.7
214

315
### Features

packages/store/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"name": "ng2-redux",
3-
"version": "3.3.8",
3+
"version": "3.3.9",
44
"description": "Angular 2 bindings for Redux",
55
"main": "./lib/index.js",
66
"scripts": {
7-
"build": "rimraf ./lib; tsc",
7+
"build": "rimraf ./lib; npm uninstall @types/chai @types/sinon-chai; tsc; npm install @types/[email protected] @types/[email protected]",
88
"test": "rimraf coverage && npm run lint && npm run cover",
99
"mocha": "mocha --opts mocha.opts",
1010
"lint": "tslint 'src/**/*.ts' 'examples/counter/**.ts' --exclude 'examples/counter/node_modules'",

0 commit comments

Comments
 (0)