Skip to content

Commit 62caa5f

Browse files
eslint-config: set jsx-a11y/accessible-emoji to off
From some testing on os x with VoiceOver, it seems the guidance provided in the rule jsx-a11y/accessible-emoji leads to a degraded experience with the label not being announced to the user. See [issue here](jsx-eslint/eslint-plugin-jsx-a11y#627)
1 parent 159fe6b commit 62caa5f

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

src/eslint-config-adeira/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Unreleased
22

3+
- set `jsx-a11y/accessible-emoji` rule to off, since it is deprecated and creates a degraded experience: [see](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/627)
34
- New rules `@next/next/inline-script-id`, `@next/next/no-script-in-document` and `@next/next/no-script-in-head` enabled (as warnings). For more information visit: https://nextjs.org/docs/basic-features/eslint#eslint-plugin
45
- We clarified what to do when you are using `@adeira/eslint-config/next` preset inside monorepo (check our readme). Basically, you might encounter the following warning:
56

src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ Object {
366366
"jest/valid-expect": 2,
367367
"jest/valid-expect-in-promise": 2,
368368
"jest/valid-title": 2,
369-
"jsx-a11y/accessible-emoji": 2,
369+
"jsx-a11y/accessible-emoji": 0,
370370
"jsx-a11y/alt-text": 2,
371371
"jsx-a11y/anchor-has-content": 2,
372372
"jsx-a11y/anchor-is-valid": 2,

src/eslint-config-adeira/__tests__/__snapshots__/presets.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,7 @@ Object {
800800
2,
801801
"all",
802802
],
803-
"jsx-a11y/accessible-emoji": 2,
803+
"jsx-a11y/accessible-emoji": 0,
804804
"jsx-a11y/alt-text": 2,
805805
"jsx-a11y/anchor-has-content": 2,
806806
"jsx-a11y/anchor-is-valid": 2,

src/eslint-config-adeira/src/presets/react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ module.exports = ({
176176
'react-native/split-platform-components': OFF,
177177

178178
// React Accessibility (https://github.com/evcohen/eslint-plugin-jsx-a11y)
179-
'jsx-a11y/accessible-emoji': ERROR,
179+
'jsx-a11y/accessible-emoji': OFF,
180180
'jsx-a11y/alt-text': ERROR,
181181
'jsx-a11y/anchor-has-content': ERROR,
182182
'jsx-a11y/anchor-is-valid': ERROR,

0 commit comments

Comments
 (0)