BUG: ensure consistent behavior of Index.is_all_dates (pandas-dev#19204)

Author: adam

doc/source/whatsnew/v1.1.0.rst

@@ -636,6 +636,7 @@ Indexing
 - Bug in :meth:`Series.__getitem__` allowing missing labels with ``np.ndarray``, :class:`Index`, :class:`Series` indexers but not ``list``, these now all raise ``KeyError`` (:issue:`33646`)
 - Bug in :meth:`DataFrame.truncate` and :meth:`Series.truncate` where index was assumed to be monotone increasing (:issue:`33756`)
 - Indexing with a list of strings representing datetimes failed on :class:`DatetimeIndex` or :class:`PeriodIndex`(:issue:`11278`)
+- Bug in :meth:`Index.is_all_dates` incorrectly returning ``False`` when inferred type of index was other dates than datetime (:issue:`19204`)
 
 Missing
 ^^^^^^^

pandas/core/indexes/base.py

@@ -1951,7 +1951,14 @@ def is_all_dates(self) -> bool:
         """
         Whether or not the index values only consist of dates.
         """
-        return is_datetime_array(ensure_object(self._values))
+        return self.inferred_type in [
+            "datetime64",
+            "datetime",
+            "date",
+            "timedelta64",
+            "timedelta",
+            "period",
+        ]
 
     # --------------------------------------------------------------------
     # Pickle Methods

pandas/tests/indexes/test_base.py

@@ -1160,6 +1160,16 @@ def test_is_object(self, indices, expected):
     def test_is_all_dates(self, indices, expected):
         assert indices.is_all_dates is expected
 
+    @pytest.mark.parametrize(
+        "index",
+        ["datetime", "datetime-tz", "period", "timedelta", "empty"],
+        indirect=["index"],
+    )
+    def test_is_all_dates_consistency(self, index):
+        # GH 19204
+        non_date = pd.Index(["not a date"])
+        assert index.is_all_dates == index.append(non_date)[:-1].is_all_dates
+
     def test_summary(self, indices):
         self._check_method_works(Index._summary, indices)