Skip to content

Bad circup instructions #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Neradoc opened this issue Oct 16, 2022 · 0 comments · Fixed by #215
Closed

Bad circup instructions #207

Neradoc opened this issue Oct 16, 2022 · 0 comments · Fixed by #215
Assignees
@tekktrik
Labels
bug

Comments

@Neradoc
Copy link
Contributor

Neradoc commented Oct 16, 2022

The circup instructions in the readme are generated as such:

circup install {{ cookiecutter.library_name | lower | replace(" ", "-") }}

This leads to instructions like: circup install ducky or circup install ltr329-ltr303

  • it should use underscores and not dash in the library name
  • it is missing the library prefix: adafruit_ (or other if present)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tekktrik tekktrik

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix circup installation instructions tekktrik/cookiecutter-adafruit-circuitpython
2 participants
@Neradoc @tekktrik