Skip to content

Commit 0119cf9

Browse files
committed
be more explicit in 'common_funcs' usage
1 parent 4e34c2b commit 0119cf9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

adabot/lib/circuitpython_library_validators.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from adabot import github_requests as github
2828
from adabot import travis_requests as travis
2929
from adabot import pypi_requests as pypi
30-
from adabot.lib.common_funcs import *
30+
from adabot.lib import common_funcs
3131

3232

3333
# Define constants for error strings to make checking against them more robust:
@@ -169,7 +169,7 @@ def validate_repo_state(self, repo):
169169
errors.append(ERROR_MISSING_LICENSE)
170170
if not repo["permissions"]["push"]:
171171
errors.append(ERROR_MISSING_LIBRARIANS)
172-
if not is_repo_in_bundle(full_repo["clone_url"], self.bundle_submodules) and \
172+
if not common_funcs.is_repo_in_bundle(full_repo["clone_url"], self.bundle_submodules) and \
173173
not repo["name"] in BUNDLE_IGNORE_LIST: # Don't assume the bundle will
174174
# bundle itself and possibly
175175
# other repos.
@@ -588,9 +588,9 @@ def validate_readthedocs(self, repo):
588588
return [ERROR_RTD_SUBPROJECT_FAILED]
589589
rtd_subprojects = {}
590590
for subproject in rtd_response.json()["subprojects"]:
591-
rtd_subprojects[sanitize_url(subproject["repo"])] = subproject
591+
rtd_subprojects[common_funcs.sanitize_url(subproject["repo"])] = subproject
592592

593-
repo_url = sanitize_url(repo["clone_url"])
593+
repo_url = common_funcs.sanitize_url(repo["clone_url"])
594594
if repo_url not in rtd_subprojects:
595595
return [ERROR_RTD_SUBPROJECT_MISSING]
596596

@@ -789,6 +789,6 @@ def validate_in_pypi(self, repo):
789789
if not (repo["owner"]["login"] == "adafruit" and
790790
repo["name"].startswith("Adafruit_CircuitPython")):
791791
return []
792-
if not repo_is_on_pypi(repo):
792+
if not common_funcs.repo_is_on_pypi(repo):
793793
return [ERROR_NOT_ON_PYPI]
794794
return []

0 commit comments

Comments
 (0)