Skip to content

License information missing from run_local_actions.sh #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
makermelissa opened this issue Oct 1, 2020 · 10 comments · Fixed by #11
Closed

License information missing from run_local_actions.sh #10

makermelissa opened this issue Oct 1, 2020 · 10 comments · Fixed by #11

Comments

@makermelissa
Copy link
Collaborator

I'm now getting the following error on pre-commit run --all-files

# MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:
* actions-ci/run_local_actions.sh
@caternuson
Copy link
Contributor

welcome to the club?
adafruit/Adafruit_CircuitPython_MS8607#4 (comment)

@makermelissa
Copy link
Collaborator Author

makermelissa commented Oct 1, 2020

Want to review my PR to fix this @caternuson?

@caternuson
Copy link
Contributor

Looks OK. But I know pretty much nothing about the "reuse" stuff. Also not sure I understand why the CI is checking its own scripts? Seems unrelated to the repo code?

@makermelissa
Copy link
Collaborator Author

Thanks. It just checks everything by default. I think the point is to make updating licenses simpler instead of including a large block of text in each file.

@evaherrada
Copy link
Collaborator

Uh, so I just merged the PR without reading the issue and I'm not entirely sure if that was the right thing to do. Let me know and I can revert it.

@makermelissa
Copy link
Collaborator Author

It just needed a licensing block of text at the top. No functional changes.

@caternuson
Copy link
Contributor

@dherrada Probably OK. It's just some text.

Should there be CI for the CI? Like something that runs here to make sure all the items here are OK?

@makermelissa
Copy link
Collaborator Author

Verified this is now fixed.

@makermelissa
Copy link
Collaborator Author

@caternuson yeah. There should probably be a test like pre-commit hooks that checks for the license info.

@caternuson
Copy link
Contributor

Worked for me too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants