-
Notifications
You must be signed in to change notification settings - Fork 7
License information missing from run_local_actions.sh #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
welcome to the club? |
Want to review my PR to fix this @caternuson? |
Looks OK. But I know pretty much nothing about the "reuse" stuff. Also not sure I understand why the CI is checking its own scripts? Seems unrelated to the repo code? |
Thanks. It just checks everything by default. I think the point is to make updating licenses simpler instead of including a large block of text in each file. |
Uh, so I just merged the PR without reading the issue and I'm not entirely sure if that was the right thing to do. Let me know and I can revert it. |
It just needed a licensing block of text at the top. No functional changes. |
@dherrada Probably OK. It's just some text. Should there be CI for the CI? Like something that runs here to make sure all the items here are OK? |
Verified this is now fixed. |
@caternuson yeah. There should probably be a test like pre-commit hooks that checks for the license info. |
Worked for me too. Thanks! |
I'm now getting the following error on
pre-commit run --all-files
The text was updated successfully, but these errors were encountered: