Merge pull request #166 from craigargh/master

Pylint

Author: kattni

.gitignore

@@ -1,2 +1,3 @@
 *~
 Hue_Controller/secrets.h
+.idea

.pylintrc

@@ -52,7 +52,7 @@ confidence=
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
 # disable=import-error,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call
-disable=too-many-instance-attributes,len-as-condition,too-few-public-methods,anomalous-backslash-in-string,no-else-return,simplifiable-if-statement,too-many-arguments,duplicate-code,no-name-in-module,no-member,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call,import-error,missing-docstring,invalid-name,bad-whitespace, --msg-template='{path} {line}: {msg} ({symbol})' */*.py
+disable=too-many-instance-attributes,len-as-condition,too-few-public-methods,anomalous-backslash-in-string,no-else-return,simplifiable-if-statement,too-many-arguments,duplicate-code,no-name-in-module,no-member,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call,import-error,missing-docstring,invalid-name,bad-whitespace,unused-variable
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
@@ -72,7 +72,7 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme
 
 # Template used to display messages. This is a python new-style format string
 # used to format the message information. See doc for all details
-#msg-template=
+msg-template='{path} {line}: {msg} ({symbol})'
 
 # Set the output format. Available formats are text, parseable, colorized, json
 # and msvs (visual studio).You can also give a reporter class, eg

3D_Printed_Guardian_Sword/3D_Printed_Guardian_Sword.py

@@ -1,49 +1,50 @@
 # 3D_Printed_Guardian_Sword
 # https://learn.adafruit.com/breath-of-the-wild-guardian-sword-led-3d-printed
 
+import time
+
 import board
 import neopixel
-import time
 
-pin = board.D4      # DIGITAL IO pin for NeoPixel OUTPUT from GEMMA
-pixel_count = 93    # number of neopixels
-delayval = .01      # 10 ms delay
+pin = board.D4  # DIGITAL IO pin for NeoPixel OUTPUT from GEMMA
+pixel_count = 93  # number of neopixels
+delayval = .01  # 10 ms delay
 
-APIXELS = 14        # number of first orange pixels
-BPIXELS = 84        # number of blue pixels
-CPIXELS = 93        # second orange pixels
+APIXELS = 14  # number of first orange pixels
+BPIXELS = 84  # number of blue pixels
+CPIXELS = 93  # second orange pixels
 
 # initialize neopixels
 pixels = neopixel.NeoPixel(pin, pixel_count, brightness=1, auto_write=False)
 
 while True:
 
-    # For the first 14 pixels, make them orange, 
+    # For the first 14 pixels, make them orange,
     # starting from pixel number 0.
-    for i in range( 0, APIXELS ):
-        # Set Pixels to Orange Color       
-        pixels[i] = ( 255, 50, 0 ) 
+    for i in range(0, APIXELS):
+        # Set Pixels to Orange Color
+        pixels[i] = (255, 50, 0)
         # This sends the updated pixel color to the hardware.
-        pixels.write()      
-        # Delay for a period of time (in milliseconds).   
-        time.sleep(delayval)   
+        pixels.write()
+        # Delay for a period of time (in milliseconds).
+        time.sleep(delayval)
 
-    # Fill up 84 pixels with blue, 
+    # Fill up 84 pixels with blue,
     # starting with pixel number 14.
-    for i in range ( 14, BPIXELS ):
-        # Set Pixels to Orange Color       
-        pixels[i] = ( 0, 250, 200 ) 
+    for i in range(14, BPIXELS):
+        # Set Pixels to Orange Color
+        pixels[i] = (0, 250, 200)
         # This sends the updated pixel color to the hardware.
-        pixels.write()      
-        # Delay for a period of time (in milliseconds).   
-        time.sleep(delayval)   
+        pixels.write()
+        # Delay for a period of time (in milliseconds).
+        time.sleep(delayval)
 
-    # Fill up 9 pixels with orange, 
+    # Fill up 9 pixels with orange,
     # starting from pixel number 84.
-    for i in range ( 84, CPIXELS ):
-        # Set Pixels to Orange Color       
-        pixels[i] =  ( 250, 50, 0 ) 
+    for i in range(84, CPIXELS):
+        # Set Pixels to Orange Color
+        pixels[i] = (250, 50, 0)
         # This sends the updated pixel color to the hardware.
-        pixels.write()      
-        # Delay for a period of time (in milliseconds).   
-        time.sleep(delayval)   
+        pixels.write()
+        # Delay for a period of time (in milliseconds).
+        time.sleep(delayval)

3D_Printed_LED_Microphone_Flag/3D_Printed_LED_Microphone_Flag.py

@@ -27,42 +27,46 @@
 # Modified fromhere code by Greg Shakar
 # Ported to Circuit Python by Mikey Sklar
 
+import time
+
 import board
 import neopixel
-import time
 from analogio import AnalogIn
-import array
-
-n_pixels    = 16                    # Number of pixels you are using
-mic_pin     = AnalogIn(board.A1)    # Microphone is attached to this analog pin
-led_pin     = board.D1              # NeoPixel LED strand is connected to this pin
-sample_window = .1                  # Sample window for average level
-peak_hang = 24                      # Time of pause before peak dot falls
-peak_fall = 4                       # Rate of falling peak dot
-input_floor = 10                    # Lower range of analogRead input
-input_ceiling = 300                 # Max range of analogRead input, the lower the value the more sensitive (1023 = max)
-
-peak = 16                           # Peak level of column; used for falling dots
+
+n_pixels = 16  # Number of pixels you are using
+mic_pin = AnalogIn(board.A1)  # Microphone is attached to this analog pin
+led_pin = board.D1  # NeoPixel LED strand is connected to this pin
+sample_window = .1  # Sample window for average level
+peak_hang = 24  # Time of pause before peak dot falls
+peak_fall = 4  # Rate of falling peak dot
+input_floor = 10  # Lower range of analogRead input
+# Max range of analogRead input, the lower the value the more sensitive
+# (1023 = max)
+input_ceiling = 300
+
+peak = 16  # Peak level of column; used for falling dots
 sample = 0
 
-dotcount = 0                        # Frame counter for peak dot
-dothangcount = 0                    # Frame counter for holding peak dot
+dotcount = 0  # Frame counter for peak dot
+dothangcount = 0  # Frame counter for holding peak dot
 
 strip = neopixel.NeoPixel(led_pin, n_pixels, brightness=1, auto_write=False)
 
+
 def wheel(pos):
     # Input a value 0 to 255 to get a color value.
     # The colours are a transition r - g - b - back to r.
-    if (pos < 0) or (pos > 255):
+    if pos < 0 or pos > 255:
         return (0, 0, 0)
-    if (pos < 85):
-        return (int(pos * 3), int(255 - (pos*3)), 0)
-    elif (pos < 170):
+    if pos < 85:
+        return (int(pos * 3), int(255 - (pos * 3)), 0)
+    elif pos < 170:
         pos -= 85
-        return (int(255 - pos*3), 0, int(pos*3))
+        return (int(255 - pos * 3), 0, int(pos * 3))
     else:
         pos -= 170
-        return (0, int(pos*3), int(255 - pos*3))
+        return (0, int(pos * 3), int(255 - pos * 3))
+
 
 def remapRange(value, leftMin, leftMax, rightMin, rightMax):
     # this remaps a value fromhere original (left) range to new (right) range
@@ -76,91 +80,89 @@ def remapRange(value, leftMin, leftMax, rightMin, rightMax):
     # Convert the 0-1 range into a value in the right range.
     return int(rightMin + (valueScaled * rightSpan))
 
+
 def fscale(originalmin, originalmax, newbegin, newend, inputvalue, curve):
-    originalrange = 0
-    newrange = 0
-    zerorefcurval = 0
-    normalizedcurval = 0
-    rangedvalue = 0
     invflag = 0
 
     # condition curve parameter
     # limit range
-    if (curve > 10): 
+    if curve > 10:
         curve = 10
-    if (curve < -10): 
+    if curve < -10:
         curve = -10
 
-    # - invert and scale - 
-    # this seems more intuitive 
+    # - invert and scale -
+    # this seems more intuitive
     # postive numbers give more weight to high end on output
-    curve = (curve * -.1) 
-    curve = pow(10, curve)  # convert linear scale into lograthimic exponent for other pow function
+    curve = (curve * -.1)
+    # convert linear scale into lograthimic exponent for other pow function
+    curve = pow(10, curve)
 
     # Check for out of range inputValues
-    if (inputvalue < originalmin):
+    if inputvalue < originalmin:
         inputvalue = originalmin
 
-    if (inputvalue > originalmax):
+    if inputvalue > originalmax:
         inputvalue = originalmax
 
     # Zero Refference the values
     originalrange = originalmax - originalmin
 
-    if (newend > newbegin):
+    if newend > newbegin:
         newrange = newend - newbegin
     else:
         newrange = newbegin - newend
         invflag = 1
 
     zerorefcurval = inputvalue - originalmin
-    normalizedcurval  =  zerorefcurval / originalrange # normalize to 0 - 1 float
+    # normalize to 0 - 1 float
+    normalizedcurval = zerorefcurval / originalrange
 
-    # Check for originalMin > originalMax  
-    # -the math for all other cases 
+    # Check for originalMin > originalMax
+    # -the math for all other cases
     # i.e. negative numbers seems to work out fine
-    if (originalmin > originalmax ):
-        return(0)
-
-    if (invflag == 0):
-        rangedvalue =  (pow(normalizedcurval, curve) * newrange) + newbegin
-    else:         # invert the ranges
-        rangedvalue =  newbegin - (pow(normalizedcurval, curve) * newrange);
+    if originalmin > originalmax:
+        return 0
 
-    return(rangedvalue)
+    if invflag == 0:
+        rangedvalue = (pow(normalizedcurval, curve) * newrange) + newbegin
+    else:  # invert the ranges
+        rangedvalue = newbegin - (pow(normalizedcurval, curve) * newrange)
 
-def drawLine(fromhere, to):
+    return rangedvalue
 
-    fromheretemp = 0
 
-    if (fromhere > to):
+def drawLine(fromhere, to):
+    if fromhere > to:
         fromheretemp = fromhere
         fromhere = to
         to = fromheretemp
 
-    for i in range(fromhere, to):
-        strip[i] = (0,0,0)
+    for index in range(fromhere, to):
+        strip[index] = (0, 0, 0)
+
 
 while True:
 
-    time_start = time.monotonic()   # current time used for sample window
-    peaktopeak = 0                  # peak-to-peak level
+    time_start = time.monotonic()  # current time used for sample window
+    peaktopeak = 0  # peak-to-peak level
     signalmax = 0
-    signalmin = 1023 
+    signalmin = 1023
     c = 0
     y = 0
 
     # collect data for length of sample window (in seconds)
-    while ( ( time.monotonic() - time_start ) < sample_window):
+    while (time.monotonic() - time_start) < sample_window:
 
-        sample = mic_pin.value / 64 # convert to arduino 10-bit [1024] fromhere 16-bit [65536]
+        # convert to arduino 10-bit [1024] fromhere 16-bit [65536]
+        sample = mic_pin.value / 64
 
-        if (sample < 1024):         # toss out spurious readings
+        if sample < 1024:  # toss out spurious readings
 
-            if (sample > signalmax):
-                signalmax = sample      # save just the max levels
-            elif (sample < signalmin):
-                signalmin = sample      # save just the min levels
+            if sample > signalmax:
+                signalmax = sample  # save just the max levels
+            elif sample < signalmin:
+                signalmin = sample  # save just the min levels
 
     peaktopeak = signalmax - signalmin  # max - min = peak-peak amplitude
 
@@ -171,11 +173,11 @@ def drawLine(fromhere, to):
     # Scale the input logarithmically instead of linearly
     c = fscale(input_floor, input_ceiling, (n_pixels - 1), 0, peaktopeak, 2)
 
-    if (c < peak): 
-        peak = c                # keep dot on top
-        dothangcount = 0        # make the dot hang before falling
+    if c < peak:
+        peak = c  # keep dot on top
+        dothangcount = 0  # make the dot hang before falling
 
-    if (c <= n_pixels):         # fill partial column with off pixels
+    if c <= n_pixels:  # fill partial column with off pixels
         drawLine(n_pixels, n_pixels - int(c))
 
     # Set the peak dot to match the rainbow gradient
@@ -184,8 +186,9 @@ def drawLine(fromhere, to):
     strip.write()
 
     # Frame based peak dot animation
-    if(dothangcount > peak_hang):           # Peak pause length
-        if(++dotcount >= peak_fall):        # Fall rate
+    if dothangcount > peak_hang:  # Peak pause length
+        dotcount += 1
+        if dotcount >= peak_fall:  # Fall rate
             peak += 1
             dotcount = 0
     else: