Made changes to types requested in review. Additionally removed all 'Any' types for unused parameters. Replaced with types from CPython.

Author: BiffoBear

adafruit_wiznet5k/adafruit_wiznet5k.py

@@ -418,7 +418,7 @@ def remote_port(self, socket_num: int) -> Union[int, bytearray]:
     @property
     def ifconfig(
         self,
-    ) -> Tuple[bytearray, bytearray, bytearray, Tuple[int, int, int, int]]:  # *1
+    ) -> Tuple[bytearray, bytearray, bytearray, Tuple[int, int, int, int]]:
         """
         Network configuration information.
 
@@ -1143,7 +1143,7 @@ def _write_socket(self, sock: int, address: int, data: int) -> None:
             )
         return None
 
-    def _read_socket(self, sock: int, address: int) -> Optional[bytearray]:  # *1
+    def _read_socket(self, sock: int, address: int) -> Optional[bytearray]:
         """Read a W5k socket register."""
         if self._chip_type == "w5500":
             cntl_byte = (sock << 5) + 0x08

adafruit_wiznet5k/adafruit_wiznet5k_dhcp.py

@@ -98,7 +98,7 @@ def __init__(
         eth: WIZNET5K,
         mac_address: Sequence[Union[int, bytes]],
         hostname: Optional[str] = None,
-        response_timeout: float = 30,
+        response_timeout: float = 30.0,
         debug: bool = False,
     ) -> None:
         """

adafruit_wiznet5k/adafruit_wiznet5k_ntp.py

@@ -46,7 +46,7 @@ def __init__(
         """
         :param adafruit_wiznet5k.WIZNET5K iface: Wiznet 5k object.
         :param str ntp_address: The hostname of the NTP server.
-        :param int utc: Numbers of hours to offset time from UTC.
+        :param float utc: Numbers of hours to offset time from UTC.
         :param bool debug: Enable debugging output, defaults to False.
         """
         self._debug = debug

adafruit_wiznet5k/adafruit_wiznet5k_socket.py

@@ -15,7 +15,7 @@
 from __future__ import annotations
 
 try:
-    from typing import TYPE_CHECKING, Any, Optional, Tuple, List, Union
+    from typing import TYPE_CHECKING, Optional, Tuple, List, Union
 
     if TYPE_CHECKING:
         from adafruit_wiznet5k.adafruit_wiznet5k import WIZNET5K
@@ -149,17 +149,17 @@ def __init__(
         self,
         family: int = AF_INET,
         type: int = SOCK_STREAM,
-        proto: Any = 0,
+        proto: int = 0,
         fileno: Optional[int] = None,
         socknum: Optional[int] = None,
     ) -> None:
         """
         :param int family: Socket address (and protocol) family, defaults to AF_INET.
         :param int type: Socket type, use SOCK_STREAM for TCP and SOCK_DGRAM for UDP,
             defaults to SOCK_STREAM.
-        :param Any proto: Unused, retained for compatibility.
-        :param Optional[Any] fileno: Unused, retained for compatibility.
-        :param Optional[Any] socknum: Unused, retained for compatibility.
+        :param int proto: Unused, retained for compatibility.
+        :param Optional[int] fileno: Unused, retained for compatibility.
+        :param Optional[int] socknum: Unused, retained for compatibility.
         """
         if family != AF_INET:
             raise RuntimeError("Only AF_INET family supported by W5K modules.")
@@ -277,11 +277,11 @@ def bind(self, address: Tuple[Optional[str], int]) -> None:
             )
             self._buffer = b""
 
-    def listen(self, backlog: Optional[Any] = None) -> None:
+    def listen(self, backlog: Optional[int] = None) -> None:
         """
         Listen on the port specified by bind.
 
-        :param Optional[Any] backlog: Included for compatibility but ignored.
+        :param Optional[int] backlog: Included for compatibility but ignored.
         """
         assert self._listen_port is not None, "Use bind to set the port before listen!"
         _the_interface.socket_listen(self.socknum, self._listen_port)
@@ -385,7 +385,7 @@ def recv(
         # pylint: disable=too-many-branches
         self,
         bufsize: int = 0,
-        flags: Any = 0,
+        flags: int = 0,
     ) -> bytes:
         """
         Read from the connected remote address.
@@ -451,7 +451,7 @@ def recv(
         return ret
 
     def embed_recv(
-        self, bufsize: int = 0, flags: Any = 0
+        self, bufsize: int = 0, flags: int = 0
     ) -> bytes:  # pylint: disable=too-many-branches
         """
         Read from the connected remote address.
@@ -478,13 +478,13 @@ def embed_recv(
         return ret
 
     def recvfrom(
-        self, bufsize: int = 0, flags: Any = 0
+        self, bufsize: int = 0, flags: int = 0
     ) -> Tuple[bytes, Tuple[str, int]]:
         """
         Read some bytes from the connected remote address.
 
         :param int bufsize: Maximum number of bytes to receive.
-        :param Any flags: ignored, present for compatibility.
+        :param int flags: ignored, present for compatibility.
 
         :return Tuple[bytes, Tuple[str, int]]: a tuple (bytes, address)
             where address is a tuple (ip, port)
@@ -497,13 +497,13 @@ def recvfrom(
             ),
         )
 
-    def recv_into(self, buf: bytearray, nbytes: int = 0, flags: Any = 0) -> int:
+    def recv_into(self, buf: bytearray, nbytes: int = 0, flags: int = 0) -> int:
         """
         Read from the connected remote address into the provided buffer.
 
         :param bytearray buf: Data buffer
         :param nbytes: Maximum number of bytes to receive
-        :param Any flags: ignored, present for compatibility.
+        :param int flags: ignored, present for compatibility.
 
         :return int: the number of bytes received
         """
@@ -515,7 +515,7 @@ def recv_into(self, buf: bytearray, nbytes: int = 0, flags: Any = 0) -> int:
         return nbytes
 
     def recvfrom_into(
-        self, buf: bytearray, nbytes: int = 0, flags: Any = 0
+        self, buf: bytearray, nbytes: int = 0, flags: int = 0
     ) -> Tuple[int, Tuple[str, int]]:
         """
         Read some bytes from the connected remote address into the provided buffer.
@@ -540,7 +540,7 @@ def readline(self) -> bytes:
         Read a line from the socket.
 
         Attempt to return as many bytes as we can up to but not including a carriage return and
-        linefeed charater pair.
+        linefeed character pair.
 
         :return bytes: The data read from the socket.
         """