linty linty

Author: brentru

adafruit_wiznet5k/adafruit_wiznet5k.py

@@ -208,7 +208,7 @@ def set_dhcp(self, response_timeout=1):
                         _dhcp_client.gateway_ip[2], _dhcp_client.gateway_ip[3])
 
             self._dns = (_dhcp_client.dns_server_ip[0], _dhcp_client.dns_server_ip[1],
-                              _dhcp_client.dns_server_ip[2], _dhcp_client.dns_server_ip[3])
+                         _dhcp_client.dns_server_ip[2], _dhcp_client.dns_server_ip[3])
             self.ifconfig = ((_ip, _subnet_mask, _gw_addr, self._dns))
             return 0
         self._src_port = 0

adafruit_wiznet5k/adafruit_wiznet5k_dhcp.py

@@ -120,7 +120,8 @@ def __init__(self, eth, mac_address, timeout=1, timeout_response=1):
     def send_dhcp_message(self, state, time_elapsed):
         """Assemble and send a DHCP message packet to a socket.
         :param int state: DHCP Message state.
-        :param float time_elapsed: Number of seconds elapsed since client attempted to acquire/renew a lease.
+        :param float time_elapsed: Number of seconds elapsed since
+                                   client attempted to acquire/renew a lease.
 
         """
         # OP

adafruit_wiznet5k/adafruit_wiznet5k_dns.py

@@ -36,6 +36,8 @@
 import adafruit_wiznet5k.adafruit_wiznet5k_socket as socket
 from adafruit_wiznet5k.adafruit_wiznet5k_socket import htons
 
+# pylint: disable=bad-whitespace
+
 QUERY_FLAG             = const(0x00)
 OPCODE_STANDARD_QUERY  = const(0x00)
 RECURSION_DESIRED_FLAG = 1<<8
@@ -51,7 +53,8 @@
 TRUNCATED        = const(-3)
 INVALID_RESPONSE = const(-4)
 
-DNS_PORT = const(0x35) # port used for DNS request
+DNS_PORT         = const(0x35) # port used for DNS request
+# pylint: enable=bad-whitespace
 
 class DNS:
     """W5K DNS implementation.
@@ -91,8 +94,8 @@ def gethostbyname(self, hostname):
         addr = -1
         while (retries < 3) and (addr == -1):
             addr = self._parse_dns_response()
-            retries+=1
-        
+            retries += 1
+
         self._sock.close()
         return addr
 
@@ -116,7 +119,6 @@ def _parse_dns_response(self):
         # Validate request identifier
         if not hex(int.from_bytes(self._pkt_buf[0:2], 'l')) == hex(self._request_id):
             return -1
-
         # Validate flags
         if not int.from_bytes(self._pkt_buf[2:4], 'l') == 0x8180:
             return -1
@@ -136,11 +138,8 @@ def _parse_dns_response(self):
                     return -1
                 # return the address
                 return self._pkt_buf[51:55]
-            else:
-                # not the correct answer type or class
-                an_count+=1
-
-        return -1
+            # not the correct answer type or class
+            an_count += 1
 
     def _build_dns_header(self):
         """Builds DNS header."""
@@ -186,5 +185,3 @@ def _build_dns_question(self):
         # Class IN
         self._pkt_buf.append(htons(CLASS_IN) & 0xFF)
         self._pkt_buf.append(htons(CLASS_IN) >> 8)
-
-

adafruit_wiznet5k/adafruit_wiznet5k_socket.py

@@ -60,6 +60,7 @@ def htons(x):
 # keep track of sockets we allocate
 SOCKETS = []
 
+#pylint: disable=too-many-arguments, unused-argument
 def getaddrinfo(host, port, family=0, socktype=0, proto=0, flags=0):
     """Translate the host/port argument into a sequence of 5-tuples that
     contain all the necessary arguments for creating a socket connected to that service.
@@ -74,9 +75,9 @@ def gethostbyname(hostname):
     is returned as a string.
     :param str hostname: Desired hostname.
     """
-    ip = _the_interface.get_host_by_name(hostname)
-    ip = "{}.{}.{}.{}".format(ip[0], ip[1], ip[2], ip[3])
-    return ip
+    addr = _the_interface.get_host_by_name(hostname)
+    addr = "{}.{}.{}.{}".format(addr[0], addr[1], addr[2], addr[3])
+    return addr
 
 #pylint: disable=invalid-name
 class socket:
@@ -86,12 +87,12 @@ class socket:
     :param int type: Socket type.
 
     """
-    # pylint: disable=redefined-builtin
+    # pylint: disable=redefined-builtin,unused-argument
     def __init__(self, family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None, socknum=None):
         if family != AF_INET:
             raise RuntimeError("Only AF_INET family supported by W5K modules.")
         self._sock_type = type
-        self._buffer = b''
+        self._buffer = b""
         self._timeout = 0
 
         self._socknum = _the_interface.get_socket(SOCKETS)
@@ -129,10 +130,10 @@ def inet_aton(self, ip_string):
         :param str ip_string: IP Address, as a dotted-quad string.
 
         """
-        self._bufffer = b""
-        self._bufffer = [int(item) for item in ip_string.split('.')]
-        self._bufffer = bytearray(self._bufffer)
-        return self._bufffer
+        self._buffer = b''
+        self._buffer = [int(item) for item in ip_string.split('.')]
+        self._buffer = bytearray(self._buffer)
+        return self._buffer
 
     def connect(self, address, conntype=None):
         """Connect to a remote socket at address. (The format of address depends