-
Notifications
You must be signed in to change notification settings - Fork 9
Allow disabling auto-show #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think it would be as simple as that, yes, but I'm not sure I like the idea. The |
@kattni What about calling it
One extra line but I'm fine with that. And actually it would allow you to disable auto write, do some updates, then re-enable it for less intense updates after. |
The second suggestion is more what I have in mind. You're still interacting with the pixels in the same way as you are with everything else, and it's clear that |
Works for me, and easy enough. Will do a PR shortly. |
Fixed by #15 |
I'll likely just make a PR of this myself when I have a minute, but it would be nice to have an auto_write param like the DotStar and NeoPixel libraries have. In fact, that param is already set in the Trellis M4 library when it loads the NeoPixel library. I realize this library is for convenience, but having auto_write always on every pixel set absolutely kills the performance. Once I wrote a little work-around like below, the performance is 10x better:
I'm thinking it could be as simple as adding
auto_write
to the TrellisM4Express.init() method and passing it into the NeoPixel class if no one objects to just leaving it at that.The text was updated successfully, but these errors were encountered: